Review main Merged

50597[TASK] Remove undefined property iconFactory from EditFileController

Wouter Wolters CR +2 V +2 Easy +1 −3 updated 11/12/16, 06:18

Commit message

The property is not defined at all. We can retrieve the iconFactory
from the moduleTemplate.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Frank Nägler +1
  • Verified V +2
    • Georg Ringer +2
    • Frank Nägler +1

Issues 1

Files 1

Review log 56

  1. Wouter Wolters uploaded patch set 1 11/11/16, 18:59

  2. Wouter Wolters uploaded patch set 2 11/11/16, 19:00

  3. TYPO3com voted on patch set 1 V -1 11/11/16, 19:16 Completed build in 16m 50s on Fri, 11 Nov, 08:16 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4830

  4. Frank Nägler voted on patch set 2 CR +1 V +1 11/11/16, 20:10

  5. Georg Ringer voted on patch set 2 CR +2 V +2 11/12/16, 06:18

  6. Gerrit merged patch set 2 11/12/16, 06:18