Review main Merged

50607[TASK] Remove iconv support and use mbstring-polyfill

Markus Klein CR +2 V +2 Hard +425 −516 updated 12/05/16, 21:52

Commit message

We remove the iconv support in the CharsetConverter as the PHP internal
implementation of some functions differ from their mb_string pendants.
This gives us a real headache in edge-cases.

We already have the mbstring-polyfill as an indirect dependency in
the Core (by symfony), so we simply require it our own now and use
mb_string all over the places.

This renders quite a few methods of CharsetConverter useless
and we therefore deprecate those.

Review

  • Code review CR +2
    • Benni Mack +2
    • Anja Leichsenring +1
  • Verified V +2
    • Benni Mack +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 22

Show 2 more files

Review log 2130

Show 45 earlier messages
  1. Markus Klein uploaded patch set 1 11/12/16, 15:21

  2. TYPO3com voted on patch set 1 V +1 11/12/16, 15:30 Completed build in 08m 45s on Sat, 12 Nov, 04:30 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4858

  3. Markus Klein commented on patch set 1 CR -1 11/12/16, 15:57

    more to come
  4. Markus Klein uploaded patch set 2 11/12/16, 16:33

  5. Markus Klein uploaded patch set 3 11/12/16, 16:39

  1. TYPO3com voted on patch set 2 V +1 11/12/16, 16:43 Completed build in 10m 31s on Sat, 12 Nov, 05:43 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4861

  2. Markus Klein uploaded patch set 4 11/12/16, 16:47

  3. TYPO3com voted on patch set 3 V +1 11/12/16, 17:01 Completed build in 21m 53s on Sat, 12 Nov, 06:01 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4863

  4. Stefan Neufeind commented on patch set 4 CR +1 V +1 11/12/16, 17:03

    peer-created and -reviewed with Markus
  5. TYPO3com voted on patch set 4 V +1 11/12/16, 17:07 Completed build in 19m 49s on Sat, 12 Nov, 06:07 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4864

  6. Markus Klein commented on patch set 4 CR -2 11/13/16, 12:49

    has to wait for a while.
  7. Markus Klein voted on patch set 4 CR 0 11/23/16, 13:06

  8. Markus Klein uploaded patch set 5 11/23/16, 13:12

  9. TYPO3com voted on patch set 5 V +1 11/23/16, 13:15 Completed build in 03m 51s on Wed, 23 Nov, 02:15 PM Test Summary: 55589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5105

  10. Markus Klein uploaded patch set 6 11/25/16, 19:06

  11. Markus Klein uploaded patch set 7 11/25/16, 19:08

  12. TYPO3com voted on patch set 6 V +1 11/25/16, 19:11 Completed build in 04m 25s on Fri, 25 Nov, 08:11 PM Test Summary: 55589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5130

  13. TYPO3com commented on patch set 7 11/25/16, 19:14 Completed build in 06m 23s on Fri, 25 Nov, 08:14 PM Test Summary: 55589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5132

  14. Anja Leichsenring uploaded patch set 8 12/04/16, 10:39

  15. Anja Leichsenring commented on patch set 8 12/04/16, 10:40

    rebased, Markus can you have a look? There has been a whole lot of files been removed from master meanwhile.
  16. TYPO3com voted on patch set 8 V +1 12/04/16, 10:54 Completed build in 15m 06s on Sun, 4 Dec, 11:54 AM Test Summary: 54322 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5460

  17. Markus Klein commented on patch set 8 12/04/16, 12:29

    wilko
  18. Markus Klein commented on patch set 8 CR -1 12/04/16, 12:38

    We need to adjust the rsts
  19. Markus Klein uploaded patch set 9 12/04/16, 12:44

  20. Markus Klein commented on patch set 9 12/04/16, 12:44

    @Anja: Ready again. Thx for rebase.
  21. TYPO3com voted on patch set 9 V +1 12/04/16, 12:49 Completed build in 05m 15s on Sun, 4 Dec, 01:49 PM Test Summary: 54322 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5506

  22. Anja Leichsenring voted on patch set 9 CR +1 V +1 12/04/16, 12:53

  23. Benni Mack voted on patch set 9 CR +2 V +2 12/05/16, 05:35

  24. Gerrit merged patch set 9 12/05/16, 05:35

  25. Markus Klein commented on patch set 10 12/05/16, 21:52

    Post-note: I didn't realize that the rebase done by Anja updates also all other composer dependencies. (composer update was run instead of composer update --lock) So it should be noted that this patch also brought all our composer dependencies back to latest state.