50607[TASK] Remove iconv support and use mbstring-polyfill
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Anja Leichsenring +1
-
Verified V +2
- Benni Mack +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 22
- typo3/sysext/compatibility7/Classes/Controller/SearchFormController.php+6 −6
- typo3/sysext/core/Classes/Charset/CharsetConverter.php+57 −228
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+3 −10
- typo3/sysext/core/Classes/Encoder/JavaScriptEncoder.php+2 −2
- typo3/sysext/core/Classes/Resource/Driver/AbstractHierarchicalFilesystemDriver.php+1 −1
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+3 −4
- typo3/sysext/core/Documentation/Changelog/8.0/Breaking-72497-RemovedRecodeSupportForCharsetConversion.rst+2 −3
- typo3/sysext/core/Documentation/Changelog/8.0/Feature-72337-CharsetConversionAutodetection.rst+2 −7
- typo3/sysext/core/Documentation/Changelog/8.3/Deprecation-76804-DeprecateGeneralUtilitystrtoupperStrtolower.rst+4 −6
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-78670-DeprecatedCharsetConverterMethods.rstnew+48 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/Query.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CaseViewHelper.php+4 −14
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+9 −15
- typo3/sysext/frontend/Classes/Imaging/GifBuilder.php+1 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+3 −3
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+6 −6
- typo3/sysext/indexed_search/Classes/Indexer.php+1 −1
- typo3/sysext/indexed_search/Classes/Lexer.php+3 −3
- typo3/sysext/rtehtmlarea/Classes/Controller/SpellCheckingController.php+2 −2
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateObjectBrowserModuleFunctionController.php+2 −5
Show 2 more files
Review log 2130
Show 45 earlier messages
-
Markus Klein uploaded patch set 1 11/12/16, 15:21
-
TYPO3com voted on patch set 1 V +1 11/12/16, 15:30 Completed build in 08m 45s on Sat, 12 Nov, 04:30 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4858
-
Markus Klein commented on patch set 1 CR -1 11/12/16, 15:57
more to come -
Markus Klein uploaded patch set 2 11/12/16, 16:33
-
Markus Klein uploaded patch set 3 11/12/16, 16:39
-
TYPO3com voted on patch set 2 V +1 11/12/16, 16:43 Completed build in 10m 31s on Sat, 12 Nov, 05:43 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4861
-
Markus Klein uploaded patch set 4 11/12/16, 16:47
-
TYPO3com voted on patch set 3 V +1 11/12/16, 17:01 Completed build in 21m 53s on Sat, 12 Nov, 06:01 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4863
-
Stefan Neufeind commented on patch set 4 CR +1 V +1 11/12/16, 17:03
peer-created and -reviewed with Markus -
TYPO3com voted on patch set 4 V +1 11/12/16, 17:07 Completed build in 19m 49s on Sat, 12 Nov, 06:07 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4864
-
Markus Klein commented on patch set 4 CR -2 11/13/16, 12:49
has to wait for a while. -
Markus Klein voted on patch set 4 CR 0 11/23/16, 13:06
-
Markus Klein uploaded patch set 5 11/23/16, 13:12
-
TYPO3com voted on patch set 5 V +1 11/23/16, 13:15 Completed build in 03m 51s on Wed, 23 Nov, 02:15 PM Test Summary: 55589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5105
-
Markus Klein uploaded patch set 6 11/25/16, 19:06
-
Markus Klein uploaded patch set 7 11/25/16, 19:08
-
TYPO3com voted on patch set 6 V +1 11/25/16, 19:11 Completed build in 04m 25s on Fri, 25 Nov, 08:11 PM Test Summary: 55589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5130
-
TYPO3com commented on patch set 7 11/25/16, 19:14 Completed build in 06m 23s on Fri, 25 Nov, 08:14 PM Test Summary: 55589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5132
-
Anja Leichsenring uploaded patch set 8 12/04/16, 10:39
-
Anja Leichsenring commented on patch set 8 12/04/16, 10:40
rebased, Markus can you have a look? There has been a whole lot of files been removed from master meanwhile. -
TYPO3com voted on patch set 8 V +1 12/04/16, 10:54 Completed build in 15m 06s on Sun, 4 Dec, 11:54 AM Test Summary: 54322 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5460
-
Markus Klein commented on patch set 8 12/04/16, 12:29
wilko -
Markus Klein commented on patch set 8 CR -1 12/04/16, 12:38
We need to adjust the rsts -
Markus Klein uploaded patch set 9 12/04/16, 12:44
-
Markus Klein commented on patch set 9 12/04/16, 12:44
@Anja: Ready again. Thx for rebase. -
TYPO3com voted on patch set 9 V +1 12/04/16, 12:49 Completed build in 05m 15s on Sun, 4 Dec, 01:49 PM Test Summary: 54322 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5506
-
Anja Leichsenring voted on patch set 9 CR +1 V +1 12/04/16, 12:53
-
Benni Mack voted on patch set 9 CR +2 V +2 12/05/16, 05:35
-
Gerrit merged patch set 9 12/05/16, 05:35
-
Markus Klein commented on patch set 10 12/05/16, 21:52
Post-note: I didn't realize that the rebase done by Anja updates also all other composer dependencies. (composer update was run instead of composer update --lock) So it should be noted that this patch also brought all our composer dependencies back to latest state.