Review main Merged

50608[FEATURE] Introduce fluid data-processor for menus

Benjamin Kott CR +2 V +2 Hard +541 −0 updated 12/01/16, 13:29

Commit message

This menu processor utilizes HMENU to generate a json encoded menu
string that will be decoded again and assigned to FLUIDTEMPLATE as
variable. Additional DataProcessing is supported and will be applied
to each record.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Frans Saris +1
  • Verified V +2
    • Anja Leichsenring +2
    • Frans Saris +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1115

  1. Benjamin Kott uploaded patch set 1 11/12/16, 15:34

  2. TYPO3com voted on patch set 1 V -1 11/12/16, 15:42 Completed build in 08m 17s on Sat, 12 Nov, 04:42 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4859

  3. Benjamin Kott uploaded patch set 2 11/12/16, 15:49

  4. TYPO3com voted on patch set 2 V -1 11/12/16, 15:57 Completed build in 08m 10s on Sat, 12 Nov, 04:57 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4860

  5. Benjamin Kott uploaded patch set 3 11/26/16, 10:14

  6. TYPO3com voted on patch set 3 V -1 11/26/16, 10:19 Completed build in 05m 08s on Sat, 26 Nov, 11:19 AM Test Summary: 55589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5138

  7. Benjamin Kott uploaded patch set 4 11/26/16, 10:39

  8. TYPO3com voted on patch set 4 V +1 11/26/16, 10:43 Completed build in 04m 05s on Sat, 26 Nov, 11:43 AM Test Summary: 55589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5139

  9. Frans Saris commented on patch set 4 11/26/16, 13:29

    Looks like not all options are explained in the rst like the special from the example
  10. Benjamin Kott commented on patch set 4 11/28/16, 09:26

    Only new options are explained, all other options are already documented in HMENU docs.
  11. Frans Saris voted on patch set 4 CR +1 V +1 11/30/16, 10:32

  12. Anja Leichsenring commented on patch set 4 12/01/16, 10:07

    MenuProcessor.php:61

    sure about the constants usage here? Wasn't there anything about no deprecation for constants and therefor better avoid that?
  13. Benjamin Kott commented on patch set 4 12/01/16, 10:13

    MenuProcessor.php:61 Reply

    i did my best, i have no feelings about anything in here except the output ;)
  14. Anja Leichsenring voted on patch set 4 CR +2 V +2 12/01/16, 13:29

  15. Gerrit merged patch set 4 12/01/16, 13:29