Review TYPO3_7-6 Merged

50624[BUGFIX] Bind the cHash to the id of the "real" page

Stefan Neufeind CR +2 V +2 Easy +10 −10 updated 11/13/16, 10:10

Commit message

If a link to a mount point or a shortcut is created,
the id argument in the url points to the id of the real page,
where the mount or the shortcut points to.

This is why we need to take the id of the final page
to be hashed and not the one used to generate the link.

We also need to move cHash calculation below shortcut resolving.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2

Issues 1

Files 1

Review log 57

  1. Stefan Neufeind uploaded patch set 1 11/12/16, 23:49

  2. TYPO3com voted on patch set 1 V +1 11/13/16, 00:29 Completed build in 40m 00s on Sun, 13 Nov, 01:29 AM Test Summary: 38082 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-357

  3. Stefan Neufeind commented on patch set 1 CR -1 11/13/16, 09:46

    ContentObjectRenderer.php:6656

    $linkParameter here needs to be $page['uid']
  4. Stefan Neufeind uploaded patch set 2 11/13/16, 09:47

  5. Markus Klein voted on patch set 2 CR +2 V +2 11/13/16, 09:54

  6. Gerrit merged patch set 2 11/13/16, 09:54

  7. TYPO3com commented on patch set 2 11/13/16, 10:10 Completed build in 22m 23s on Sun, 13 Nov, 11:10 AM Test Summary: 38082 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-360