Review main Merged

50626[TASK] Remove GLOBAL variables from web_ts

Benni Mack CR +2 V +2 Hard +174 −182 updated 11/13/16, 10:23

Commit message

The system extension "tstemplate" still uses a
lot of $GLOBAL objects which are only used within
the classes itself.

These are solely related to the "web_ts" (Web => Template)
module.

The code is refactored by using protected object members.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Markus Klein +1
  • Verified V +2
    • Stefan Neufeind +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 57

  1. Benni Mack uploaded patch set 1 11/13/16, 00:10

  2. TYPO3com voted on patch set 1 V +1 11/13/16, 00:37 Completed build in 26m 59s on Sun, 13 Nov, 01:37 AM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4877

  3. Markus Klein uploaded patch set 2 11/13/16, 09:25

  4. Markus Klein voted on patch set 2 CR +1 V +1 11/13/16, 09:26

  5. TYPO3com voted on patch set 2 V +1 11/13/16, 09:33 Completed build in 07m 41s on Sun, 13 Nov, 10:33 AM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4879

  6. Stefan Neufeind voted on patch set 2 CR +2 V +2 11/13/16, 10:23

  7. Gerrit merged patch set 2 11/13/16, 10:23