Review TYPO3_7-6 Merged

50629[TASK] Use semver for Symfony versions

Stefan Neufeind CR +2 V +2 Easy +4 −4 updated 11/23/16, 12:48

Commit message

Symfony has one of the best BC promises in the PHP world. Which means it
will be never a problem to allow all new minor versions of a supported
major release, even if there are deprecations. Deprecations don't infer
with existing code.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Markus Klein +1
  • Verified V +2
    • Stefan Neufeind +2
    • Markus Klein +1

Issues 3

Files 2

Review log 1112

  1. Stefan Neufeind uploaded patch set 1 11/13/16, 12:15

  2. Markus Klein voted on patch set 1 CR +1 V +1 11/13/16, 12:16

  3. Stefan Neufeind voted on patch set 1 CR +2 V +2 11/13/16, 12:16

  4. Gerrit merged patch set 1 11/13/16, 12:16

  5. TYPO3com commented on patch set 1 11/13/16, 12:35 Completed build in 20m 24s on Sun, 13 Nov, 01:35 PM Test Summary: 38082 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-364

  6. Mathias Brodala commented on patch set 2 11/21/16, 09:34

    Post +1 for this, thanks a lot! :-)
  7. Helmut Hummel commented on patch set 2 11/22/16, 14:23

    composer.json:40

    this specifies a wrong dependency for TYPO3 7.6. This version does not work with symfony/console 3.x as it uses classes that were removed. This change effectively breaks every composer installation using cli, as now symfony/console 3.x will be installed. If anything, we should revert this and go for https://review.typo3.org/#/c/48064/4/composer.json
  8. Mathias Brodala commented on patch set 2 11/22/16, 14:27

    composer.json:40 Reply

    You are right. I had the same idea but didn't raise my concern for whatever reasons.
  9. Markus Klein commented on patch set 2 11/22/16, 14:27

    I'm fine with either solution. Or could we fix that by improving the core code somehow? (I don't know which classes are affected)
  10. Helmut Hummel commented on patch set 2 11/22/16, 14:29

    > Or could we fix that by improving the core code somehow? Doing so would require quire some changes and removing public API, see: https://review.typo3.org/#/c/46505/
  11. Stephan Großberndt commented on patch set 2 11/23/16, 11:57

  12. Stefan Neufeind commented on patch set 2 11/23/16, 12:48

    And here's the corrected change which in itself then also fixes the regression introduced here. https://review.typo3.org/48064