50642[TASK] Fluidification of ElementInformationController
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Daniel Windloff +1
- Valentin Funk +1
- Jan Helke +1
-
Verified V +2
- Susi Moog +2
- Daniel Windloff +1
- Jan Helke +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 3138
Show 913 earlier messages
-
Michael Oehlhof uploaded patch set 1 11/13/16, 14:04
-
TYPO3com voted on patch set 1 V -1 11/13/16, 16:07 Completed build in 2h 03m 05s on Sun, 13 Nov, 05:07 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4898
-
Michael Oehlhof uploaded patch set 2 11/13/16, 20:55
-
TYPO3com voted on patch set 2 V +1 11/13/16, 21:03 Completed build in 08m 24s on Sun, 13 Nov, 10:03 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4910
-
Stefan Neufeind voted on patch set 2 CR +1 11/15/16, 15:06
-
Jörg Bösche voted on patch set 2 CR +1 11/16/16, 20:51
-
Frans Saris commented on patch set 2 11/16/16, 21:19
For the file preview just assign the file object to the view and use <f:media file=... to render the preview in the view. The whole thumb and renderer logic can be dropped in the controller -
Michael Oehlhof uploaded patch set 3 11/17/16, 12:36
-
Michael Oehlhof commented on patch set 3 11/17/16, 12:39
@Frans: I have changed the file preview according your hint. -
TYPO3com voted on patch set 3 V -1 11/17/16, 12:39 Completed build in 03m 06s on Thu, 17 Nov, 01:39 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4960
-
Michael Oehlhof uploaded patch set 4 11/17/16, 12:43
-
TYPO3com voted on patch set 4 V +1 11/17/16, 12:47 Completed build in 04m 24s on Thu, 17 Nov, 01:47 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4961
-
Stefan Neufeind voted on patch set 4 CR +1 11/17/16, 13:04
-
Daniel Windloff commented on patch set 4 11/17/16, 20:25
Hi, as the php-api of the class has been changed, I think the change should be marked as breaking. I would also opt for cleanup the ElementInformationController itself and fix some minor ux issues. I could create a new patchset if it's ok.ElementInformationController.php:106= []; ?ElementInformationController.php:125Deprecate init() and move the method content to __construct?ElementInformationController.php:258Perhaps assignPageTitle or sth like that? Reading getXY I expect a return value.ElementInformationController.php:468Add typehints for changed methods?ElementInformation.html:14f:be.infobox?ElementInformation.html:31I would opt for btn-default.ElementInformation.html:206Split to 3 icon groups: 1. actions-document-view / actions-open 2. actions-document-history-open 3. actions-system-list-open I think this would be more consistent (see list module). -
Michael Oehlhof commented on patch set 4 11/17/16, 20:55
My intention was to move the HTML code as it is to a fluid template. I would prefer to make the cleanup and ux fixes after this patch is merged. I don't want to mix the switch to fluid and other changes. -
Daniel Windloff commented on patch set 4 V +1 11/17/16, 21:06
Ok, I stuble about these things, reviewing at the code ;). I would prefer to rename the getXY, that do not return a value. -
Michael Oehlhof wrote 11/18/16, 11:19
Topic set to fluidification -
Markus Sommer voted on patch set 4 CR +1 11/27/16, 10:01
-
Jörg Bösche voted on patch set 4 CR +1 11/27/16, 21:30
-
Michael Oehlhof commented on patch set 4 12/01/16, 15:31
ElementInformation.html:14ReplyThe goal of the patch is moving the HTML from the PHP code into a fluid template. Changes and optimization of the HTML code should be made in following patches.ElementInformation.html:31ReplyThe goal of the patch is moving the HTML from the PHP code into a fluid template. Changes and optimization of the HTML code should be made in following patches.ElementInformation.html:206ReplyThe goal of the patch is moving the HTML from the PHP code into a fluid template. Changes and optimization of the HTML code should be made in following patches. -
Michael Oehlhof uploaded patch set 5 12/01/16, 15:39
-
TYPO3com voted on patch set 5 V +1 12/01/16, 15:42 Completed build in 03m 34s on Thu, 1 Dec, 04:42 PM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5257
-
Daniel Windloff voted on patch set 5 CR +1 V +1 12/01/16, 17:54
-
Valentin Funk voted on patch set 5 CR +1 V +1 12/01/16, 19:39
-
Stefan Neufeind commented on patch set 5 V +1 12/02/16, 08:05
visual comparison before/after -
Susi Moog commented on patch set 5 CR -1 12/02/16, 09:21
on it -
Susi Moog uploaded patch set 6 12/02/16, 10:00
-
Valentin Funk voted on patch set 6 CR +1 12/02/16, 10:02
-
Susi Moog commented on patch set 6 12/02/16, 10:02
rewrote the controller part so that "get..." methods actually get things (by returning arrays with the corresponding information) instead of assigning to a class var. -
TYPO3com voted on patch set 6 V +1 12/02/16, 10:05 Completed build in 05m 02s on Fri, 2 Dec, 11:05 AM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5310
-
Jan Helke uploaded patch set 7 12/02/16, 10:19
-
Jan Helke voted on patch set 7 CR +1 V +1 12/02/16, 10:22
-
TYPO3com voted on patch set 7 V +1 12/02/16, 10:23 Completed build in 04m 02s on Fri, 2 Dec, 11:23 AM Test Summary: 54089 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5313
-
Daniel Windloff voted on patch set 7 CR +1 V +1 12/02/16, 11:18
-
Valentin Funk voted on patch set 7 CR +1 12/02/16, 11:32
-
Susi Moog voted on patch set 7 CR +2 V +2 12/02/16, 11:38
-
Gerrit merged patch set 7 12/02/16, 11:38
-
Daniel Windloff commented on patch set 8 12/02/16, 12:22
Small ux fix (template): https://review.typo3.org/#/c/50851/