Review main Merged

50643[TASK] Manual require_once of crawler removal

Benni Mack CR +2 V +2 Easy +42 −1 updated 11/15/16, 08:43

Commit message

The crawler is still included via a require_once in indexed_search,
even though the class loader since TYPO3 6.2 does that transparently.

So, the method is still called, which makes it impossible to
move EXT:crawler lib to a different location inside the extension.

The patch removes the call to the method, as the autoloader
fetches the file anyway.

It also deprecates the method call within EXT:indexed_search.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Wouter Wolters +1
    • Morton Jonuschat +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Wouter Wolters +1
    • Morton Jonuschat +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 912

  1. Benni Mack uploaded patch set 1 11/13/16, 14:09

  2. TYPO3com voted on patch set 1 V -1 11/13/16, 16:14 Completed build in 2h 05m 08s on Sun, 13 Nov, 05:14 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4899

  3. Benni Mack commented on patch set 2 11/13/16, 18:55

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V +1 11/13/16, 19:04 Completed build in 08m 34s on Sun, 13 Nov, 08:04 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4906

  5. Wouter Wolters voted on patch set 2 CR +1 V +1 11/14/16, 11:09

  6. Tymoteusz Motylewski commented on patch set 2 11/14/16, 21:47

    Deprecation-78679-CrawlerInclusionViaRequire_onceInIndexedSearch.rst:27

    "customer indexer" ?

    Deprecation-78679-CrawlerInclusionViaRequire_onceInIndexedSearch.rst:36

    PHP-API also
  7. Benni Mack commented on patch set 3 11/15/16, 05:48

    Published edit on patch set 2.
  8. TYPO3com voted on patch set 3 V +1 11/15/16, 05:56 Completed build in 07m 44s on Tue, 15 Nov, 06:56 AM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4922

  9. Morton Jonuschat voted on patch set 3 CR +1 V +1 11/15/16, 07:11

  10. Wouter Wolters voted on patch set 3 CR +1 V +1 11/15/16, 07:33

  11. Tymoteusz Motylewski voted on patch set 3 CR +2 V +2 11/15/16, 08:43

  12. Gerrit merged patch set 3 11/15/16, 08:43