Review main Merged

50654[FEATURE] Possibility to set sessionTimeout for Frontend Users

Alexander Opitz CR +2 V +2 Easy +26 −2 updated 11/29/17, 18:24

Commit message

Currently it was only possible to set the session timeout for the backend users
You can define the sessionTimeout with the new configuration option
$GLOBALS['TYPO3_CONF_VARS']['FE']['sessionTimeout'].

Review

  • Code review CR +2
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2
    • Benni Mack +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 2536

Show 911 earlier messages
  1. Alexander Opitz uploaded patch set 1 11/14/16, 15:56

  2. Alexander Opitz commented on patch set 1 11/14/16, 15:59

    Not my preferred solution, but fastest to set. More cleanup would be welcome but would be breaking change. The issue is, that lifetime and sessionTimeout have different meaning on value 0.
  3. TYPO3com voted on patch set 1 V -1 11/14/16, 16:05 Completed build in 08m 32s on Mon, 14 Nov, 05:05 PM Test Summary: 6 of 55265 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4917

  4. Alexander Opitz updated the commit message in patch set 2 11/15/16, 08:33

  5. Andreas Kienast commented on patch set 2 11/15/16, 08:44

    IMO this is a feature
  6. TYPO3com voted on patch set 2 V -1 11/15/16, 08:50 Completed build in 17m 09s on Tue, 15 Nov, 09:50 AM Test Summary: 6 of 55265 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4924

  7. Stefan Neufeind commented on patch set 2 CR -1 11/15/16, 14:55

    Needs to be added in typo3/sysext/core/Configuration/DefaultConfiguration.php (no additional documentation needed - for that code is the documentation). And I agree this somehow is a "feature", as which it should get an RST.
  8. Alexander Opitz commented on patch set 2 11/15/16, 15:23

    I only presented a possible solution. If the solution is ok for most, I will do patches. IMHO it is more a fix of an issue as adding a new feature. BTW: What is the problem of Bamboo with this patch? This do not have todo with the Extbase blog example.
  9. Oliver Klee commented on patch set 2 11/17/16, 11:26

    Isn't this a FEATURE instead of a BUGFIX then?
  10. Stefan Neufeind commented on patch set 2 11/17/16, 11:40

    @Oliver: That's what others thought as well :-) See the comments.
  11. Alexander Opitz commented on patch set 2 11/18/16, 15:53

    Again, is the solution ok for all? If yes, I'll do another patch round.
  1. Alexander Opitz uploaded patch set 3 11/28/16, 14:42

  2. TYPO3com voted on patch set 3 V -1 11/28/16, 14:46 Completed build in 04m 31s on Mon, 28 Nov, 03:46 PM Test Summary: 6 of 55589 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5173

  3. Alexander Opitz rebased onto patch set 4 11/28/16, 14:50

  4. TYPO3com voted on patch set 4 V -1 11/28/16, 14:54 Completed build in 03m 41s on Mon, 28 Nov, 03:54 PM Test Summary: 6 of 55589 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5174

  5. TYPO3com commented on patch set 3 11/28/16, 15:31 Completed build in 54m 14s on Mon, 28 Nov, 04:31 PM Test Summary: 6 of 55589 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5173

  6. Alexander Opitz uploaded patch set 5 11/28/16, 18:02

  7. TYPO3com voted on patch set 5 V +1 11/28/16, 18:06 Completed build in 04m 07s on Mon, 28 Nov, 07:06 PM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5178

  8. Anja Leichsenring uploaded patch set 6 12/04/16, 10:32

  9. Anja Leichsenring updated the commit message in patch set 7 12/04/16, 10:33

  10. Anja Leichsenring commented on patch set 7 CR -1 12/04/16, 10:34

    feature.rst missing, and unit tests, too.
  11. TYPO3com voted on patch set 6 V -1 12/04/16, 10:39 Completed build in 06m 24s on Sun, 4 Dec, 11:39 AM Test Summary: 54322 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5453

  12. TYPO3com voted on patch set 7 V -1 12/04/16, 10:45 Completed build in 11m 20s on Sun, 4 Dec, 11:45 AM Test Summary: 54322 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5455

  13. Benni Mack commented on patch set 7 04/21/17, 13:59

    Anja's remarks still apply, care to update the patch for master now?
  14. Benni Mack commented on patch set 7 10/19/17, 21:23

    next ping
  15. Benni Mack uploaded patch set 8 11/29/17, 16:17

  16. Benni Mack commented on patch set 7 11/29/17, 16:17

    I skipped the unit tests for this, as this patch only introduces an overriding value.
  17. TYPO3com voted on patch set 8 V +1 11/29/17, 16:33 Completed build in 15m 24s on Wed, 29 Nov, 05:33 PM Test Summary: 57000 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16984

  18. Markus Klein commented on patch set 9 11/29/17, 16:48

    Published edit on patch set 8.
  19. TYPO3com voted on patch set 9 V +1 11/29/17, 16:59 Completed build in 10m 48s on Wed, 29 Nov, 05:59 PM Test Summary: 57000 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16993

  20. Markus Klein commented on patch set 9 CR -1 11/29/17, 17:06

    on it
  21. Markus Klein uploaded patch set 10 11/29/17, 18:12

  22. Markus Klein voted on patch set 10 CR +1 V +1 11/29/17, 18:12

  23. TYPO3com voted on patch set 10 V +1 11/29/17, 18:22 Completed build in 09m 45s on Wed, 29 Nov, 07:22 PM Test Summary: 57002 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17014

  24. Benni Mack voted on patch set 10 CR +2 V +2 11/29/17, 18:24

  25. Gerrit merged patch set 10 11/29/17, 18:24