50655[TASK] Fluidification of MoveElementController
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Gleb Levitin +1
- Oliver Hader +1
-
Verified V +2
- Anja Leichsenring +2
- Gleb Levitin +1
- Oliver Hader +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1721
-
Michael Oehlhof uploaded patch set 1 11/14/16, 19:04
-
TYPO3com voted on patch set 1 V -1 11/14/16, 19:15 Completed build in 10m 59s on Mon, 14 Nov, 08:15 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4918
-
Michael Oehlhof uploaded patch set 2 11/15/16, 09:10
-
TYPO3com voted on patch set 2 V +1 11/15/16, 09:20 Completed build in 09m 38s on Tue, 15 Nov, 10:20 AM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4926
-
Stefan Neufeind voted on patch set 2 CR +1 11/15/16, 15:03
-
Michael Oehlhof wrote 11/18/16, 11:19
Topic set to fluidification -
Łukasz Uznański voted on patch set 2 CR +1 11/20/16, 12:22
-
Markus Sommer voted on patch set 2 CR +1 11/27/16, 10:02
-
Jörg Bösche voted on patch set 2 CR +1 11/27/16, 21:29
-
Gleb Levitin voted on patch set 2 V -1 12/01/16, 11:34
-
Gleb Levitin commented on patch set 2 12/01/16, 11:38
Moving the content element with option "Make copy instead of moving element" (a checkbox below the headline) throws the following error: `Class 'TYPO3\CMS\Form\Hooks\DataStructureIdentifierHook' not found` -
Michael Oehlhof commented on patch set 2 12/01/16, 11:48
Just tried it, don't get this error. But found hat the headline shows the <em> tag. -
Michael Oehlhof commented on patch set 3 12/01/16, 11:51
Published edit on patch set 2. -
TYPO3com voted on patch set 3 V +1 12/01/16, 11:56 Completed build in 04m 20s on Thu, 1 Dec, 12:56 PM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5233
-
Oliver Hader commented on patch set 3 CR -1 12/01/16, 13:36
MoveElement.html:17Has to be used as variable interpolation - pages.goUpUrlMoveElement.html:35Has to be used as variable interpolation - ttContent.goUpUrl -
Oliver Hader uploaded patch set 4 12/01/16, 14:50
-
Oliver Hader voted on patch set 4 CR +1 V +1 12/01/16, 14:50
-
TYPO3com voted on patch set 4 V +1 12/01/16, 14:54 Completed build in 04m 08s on Thu, 1 Dec, 03:54 PM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5250
-
Gleb Levitin voted on patch set 4 CR +1 V +1 12/01/16, 16:53
-
Anja Leichsenring voted on patch set 4 CR +2 V +2 12/01/16, 16:54
-
Gerrit merged patch set 4 12/01/16, 16:54