Review TYPO3_7-6 Merged

50663[BUGFIX] Use GeneralUtility::getUrl in DocumentationService->fetchDocument

Claus Due CR +2 V +2 Easy +3 −5 updated 11/18/16, 16:42

Commit message

This avoids issues with frequent incompatibilities with SSLv2
in libcurl.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Markus Klein +1
  • Verified V +2
    • Andreas Kienast +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 910

  1. Claus Due uploaded patch set 1 11/15/16, 14:10

  2. TYPO3com voted on patch set 1 V +1 11/15/16, 14:21 Completed build in 11m 24s on Tue, 15 Nov, 03:21 PM Test Summary: 38082 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-379

  3. Markus Klein wrote 11/15/16, 15:45

    Topic changed from issues/78703 to http_request2
  4. Markus Klein voted on patch set 1 CR +1 11/15/16, 15:46

  5. Markus Klein voted on patch set 1 V +1 11/18/16, 10:47

  6. Andreas Kienast voted on patch set 1 CR +2 V +2 11/18/16, 11:20

  7. Gerrit merged patch set 1 11/18/16, 11:20

  8. Stephan Großberndt commented on patch set 2 11/18/16, 16:12

    The main issue here is not an incompatibility with SSLv2 but another: https://docs.typo3.org/typo3cms/documents.json delivers the documentation which is available. The "url" of each package currently has "http://docs.typo3.org"; which is outdated. The request gets redirected via 301 to "https://docs.typo3.org"; which makes `if ($response->getStatus() == 200) {` fail
  9. Stephan Großberndt commented on patch set 2 11/18/16, 16:17

    While GeneralUtility::getUrl() and Guzzle (master) seem to follow the redirect \HTTP_Request2 does not. So the patch is correct - but it should get a backport to 6.2 since it is broken there too.
  10. Stephan Großberndt commented on patch set 2 11/18/16, 16:42

    I have added a backport to 6.2 on https://review.typo3.org/#/c/50709

    DocumentationService.php:185

    Should have been if (!empty($content)) {