50664[TASK] Refactor BackendUtility::getRecordsByField() to prepared statements
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Anja Leichsenring +1
-
Verified V +2
- Susi Moog +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1621
-
Manuel Selbach uploaded patch set 1 11/15/16, 14:36
-
TYPO3com voted on patch set 1 V +1 11/15/16, 14:44 Completed build in 08m 11s on Tue, 15 Nov, 03:44 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4933
-
Mathias Schreiber updated the commit message in patch set 2 11/21/16, 13:30
-
Mathias Schreiber commented on patch set 2 CR +1 V +1 11/21/16, 13:31
I could reproduce the error, but it took me a while to figure it out. A test would be perfect here, although I wonder how that could be tested. -
TYPO3com voted on patch set 2 V +1 11/21/16, 13:35 Completed build in 04m 34s on Mon, 21 Nov, 02:35 PM Test Summary: 55331 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5077
-
Markus Klein voted on patch set 2 CR +1 11/21/16, 13:40
-
Christian Kuhn commented on patch set 2 11/21/16, 16:04
BackendUtility.php:224please add a hint here that the $queryBuilder must be added if $whereClause is NOT empty. this is the goal of the patch, if i understand correctly?BackendUtility.php:239cosmetic: i prefer not not use yoda statements. -
Manuel Selbach uploaded patch set 3 11/26/16, 12:08
-
Manuel Selbach commented on patch set 2 11/26/16, 12:10
BackendUtility.php:224ReplyDone -
TYPO3com voted on patch set 3 V +1 11/26/16, 12:13 Completed build in 04m 50s on Sat, 26 Nov, 01:13 PM Test Summary: 55589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5141
-
Markus Klein voted on patch set 3 CR +1 11/26/16, 20:17
-
Markus Klein voted on patch set 3 V +1 11/26/16, 20:19
-
Wouter Wolters voted on patch set 3 CR +1 11/29/16, 20:41
-
Anja Leichsenring uploaded patch set 4 12/03/16, 09:25
-
Anja Leichsenring voted on patch set 4 CR +1 V +1 12/03/16, 09:28
-
TYPO3com voted on patch set 4 V -1 12/03/16, 09:29 Completed build in 04m 47s on Sat, 3 Dec, 10:29 AM Test Summary: 54202 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5377
-
Anja Leichsenring uploaded patch set 5 12/03/16, 09:53
-
Anja Leichsenring voted on patch set 5 CR +1 V +1 12/03/16, 09:56
-
TYPO3com voted on patch set 5 V +1 12/03/16, 09:57 Completed build in 03m 49s on Sat, 3 Dec, 10:57 AM Test Summary: 54202 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5378
-
Susi Moog voted on patch set 5 CR +2 V +2 12/03/16, 14:07
-
Gerrit merged patch set 5 12/03/16, 14:07