Review main Merged

50686[BUGFIX] YouTubeRenderer: urlencode the origin parameter

Benjamin Franzke CR +2 V +2 Easy +7 −7 updated 11/18/16, 21:22

Commit message

Commit 84ab413 (https://review.typo3.org/49416) fixed the origin
parameter to include the full host (and thus the scheme).
The full host url was not urlencoded. As the scheme contains
slashes this has to be encoded as well.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Klein +1
    • Frans Saris +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 913

  1. Benjamin Franzke uploaded patch set 1 11/17/16, 06:01

  2. TYPO3com voted on patch set 1 V -1 11/17/16, 06:05 Completed build in 03m 53s on Thu, 17 Nov, 07:05 AM Test Summary: 36 of 55265 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4945

  3. Benjamin Franzke uploaded patch set 2 11/17/16, 06:25

  4. Benjamin Franzke uploaded patch set 3 11/17/16, 06:26

  5. TYPO3com voted on patch set 2 V -1 11/17/16, 06:28 Completed build in 03m 32s on Thu, 17 Nov, 07:28 AM Test Summary: 6 of 55265 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4946

  6. TYPO3com voted on patch set 3 V +1 11/17/16, 06:30 Completed build in 04m 01s on Thu, 17 Nov, 07:30 AM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4947

  7. Markus Klein updated the commit message in patch set 4 11/17/16, 06:43

  8. Markus Klein voted on patch set 4 CR +1 V +1 11/17/16, 06:43

  9. TYPO3com voted on patch set 4 V +1 11/17/16, 06:47 Completed build in 03m 41s on Thu, 17 Nov, 07:47 AM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4948

  10. Frans Saris voted on patch set 4 CR +1 11/17/16, 07:32

  11. Christian Kuhn voted on patch set 4 CR +2 V +2 11/18/16, 21:22

  12. Gerrit merged patch set 4 11/18/16, 21:22

  13. Christian Kuhn commented on patch set 5 11/18/16, 21:22

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit f525b1f3abacce9a21adfbe579079bfa34352980