Review main Merged

50693[TASK] Deprecate callUserFunction "&" token for persistent objects

Benni Mack CR +2 V +2 Easy +41 −0 updated 12/01/16, 17:27

Commit message

The method GeneralUtility::callUserFunction() method allows
to call "&" to put this logic into a "persistent" pool. We already
have the SingletonInterface which should be used for objects
that should be persistent.

Currently there are two "persistent object pools", one for
makeInstance and one for callUserFunc, which makes it very hard
to understand which object is used when. Reducing complexity
and using the SingletonInterface everywhere should be the best practice.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1621

  1. Benni Mack uploaded patch set 1 11/17/16, 11:05

  2. TYPO3com voted on patch set 1 V +1 11/17/16, 11:08 Completed build in 03m 24s on Thu, 17 Nov, 12:08 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4956

  3. Mathias Brodala commented on patch set 1 11/21/16, 09:45

    GeneralUtility.php:3745

    implement
  4. Mathias Brodala voted on patch set 1 CR +1 11/21/16, 09:46

  5. Benni Mack uploaded patch set 2 11/29/16, 06:24

  6. TYPO3com voted on patch set 2 V +1 11/29/16, 06:28 Completed build in 04m 14s on Tue, 29 Nov, 07:28 AM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5181

  7. Markus Klein commented on patch set 2 11/29/16, 08:21

    GeneralUtility.php:3746

    error by then.
  8. Markus Klein commented on patch set 3 11/29/16, 08:22

    Published edit on patch set 2.
  9. Markus Klein voted on patch set 3 CR +1 V +1 11/29/16, 08:22

  10. TYPO3com voted on patch set 3 V +1 11/29/16, 08:26 Completed build in 04m 13s on Tue, 29 Nov, 09:26 AM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5184

  11. Stefan Neufeind commented on patch set 3 CR +1 V +1 11/29/16, 08:27

    Deprecation-78733-CallUserFunctionTokenForSingletonObjects.rst:13

    We don't do newlines here if not necessary, right? Then there is no real reason to have it here, in the middle of a sentence.
  12. Stefan Neufeind commented on patch set 3 11/29/16, 08:30

    GeneralUtility.php:3746

    "fatal PHP error by then" is maybe meant without "by". But is it really a "PHP error"? Anyway, those are of course nitpicks :-) I'm fine with the change itself - and we should maybe have this instead of going many more baby-steps.
  13. Benni Mack commented on patch set 4 11/29/16, 09:45

    Published edit on patch set 3.
  14. Benni Mack commented on patch set 4 11/29/16, 09:45

    nitpicks changed. btw - yes, it's gonna be a fatal PHP error (well, with PHP7 it's catchable but hey ;))
  15. Mathias Brodala voted on patch set 4 CR +1 11/29/16, 09:48

  16. TYPO3com voted on patch set 4 V +1 11/29/16, 09:51 Completed build in 05m 53s on Tue, 29 Nov, 10:51 AM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5187

  17. Stefan Neufeind voted on patch set 4 CR +1 V +1 11/29/16, 10:15

  18. Oliver Hader commented on patch set 5 12/01/16, 09:29

    Published edit on patch set 4.
  19. Oliver Hader voted on patch set 5 CR +2 V +2 12/01/16, 09:30

  20. TYPO3com voted on patch set 5 V +1 12/01/16, 09:34 Completed build in 04m 55s on Thu, 1 Dec, 10:34 AM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5214

  21. Gerrit merged patch set 5 12/01/16, 17:27