50693[TASK] Deprecate callUserFunction "&" token for persistent objects
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
-
Verified V +2
- Oliver Hader +2
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1621
-
Benni Mack uploaded patch set 1 11/17/16, 11:05
-
TYPO3com voted on patch set 1 V +1 11/17/16, 11:08 Completed build in 03m 24s on Thu, 17 Nov, 12:08 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4956
-
Mathias Brodala commented on patch set 1 11/21/16, 09:45
-
Mathias Brodala voted on patch set 1 CR +1 11/21/16, 09:46
-
Benni Mack uploaded patch set 2 11/29/16, 06:24
-
TYPO3com voted on patch set 2 V +1 11/29/16, 06:28 Completed build in 04m 14s on Tue, 29 Nov, 07:28 AM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5181
-
Markus Klein commented on patch set 2 11/29/16, 08:21
GeneralUtility.php:3746error by then. -
Markus Klein commented on patch set 3 11/29/16, 08:22
Published edit on patch set 2. -
Markus Klein voted on patch set 3 CR +1 V +1 11/29/16, 08:22
-
TYPO3com voted on patch set 3 V +1 11/29/16, 08:26 Completed build in 04m 13s on Tue, 29 Nov, 09:26 AM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5184
-
Stefan Neufeind commented on patch set 3 CR +1 V +1 11/29/16, 08:27
Deprecation-78733-CallUserFunctionTokenForSingletonObjects.rst:13We don't do newlines here if not necessary, right? Then there is no real reason to have it here, in the middle of a sentence. -
Stefan Neufeind commented on patch set 3 11/29/16, 08:30
GeneralUtility.php:3746"fatal PHP error by then" is maybe meant without "by". But is it really a "PHP error"? Anyway, those are of course nitpicks :-) I'm fine with the change itself - and we should maybe have this instead of going many more baby-steps. -
Benni Mack commented on patch set 4 11/29/16, 09:45
Published edit on patch set 3. -
Benni Mack commented on patch set 4 11/29/16, 09:45
nitpicks changed. btw - yes, it's gonna be a fatal PHP error (well, with PHP7 it's catchable but hey ;)) -
Mathias Brodala voted on patch set 4 CR +1 11/29/16, 09:48
-
TYPO3com voted on patch set 4 V +1 11/29/16, 09:51 Completed build in 05m 53s on Tue, 29 Nov, 10:51 AM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5187
-
Stefan Neufeind voted on patch set 4 CR +1 V +1 11/29/16, 10:15
-
Oliver Hader commented on patch set 5 12/01/16, 09:29
Published edit on patch set 4. -
Oliver Hader voted on patch set 5 CR +2 V +2 12/01/16, 09:30
-
TYPO3com voted on patch set 5 V +1 12/01/16, 09:34 Completed build in 04m 55s on Thu, 1 Dec, 10:34 AM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5214
-
Gerrit merged patch set 5 12/01/16, 17:27
GeneralUtility.php:3745