Review main Merged

50695[TASK] Remove all $GLOBALS['rootline'] usages

Benni Mack CR +2 V +2 Easy +3 −1 updated 11/18/16, 21:14

Commit message

The getRootline() method of ExtendedTemplateService is broken
because of an incomplete replacement of the web_ts changes.

See https://review.typo3.org/#/c/50626/

The fix replaces the rootline variable in the last occurence
by the correct replacement.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 56

  1. Benni Mack uploaded patch set 1 11/17/16, 12:00

  2. TYPO3com voted on patch set 1 V +1 11/17/16, 12:04 Completed build in 03m 44s on Thu, 17 Nov, 01:04 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4958

  3. Stefan Neufeind voted on patch set 1 CR +1 11/17/16, 13:07

  4. Wouter Wolters voted on patch set 1 CR +1 V +1 11/17/16, 17:15

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 11/18/16, 21:12

  6. Gerrit merged patch set 1 11/18/16, 21:14