Review main Merged

50696[BUGFIX] Make showAccessRestrictedPages work

Claus Due CR +2 V +2 Hard +270 −2 updated 12/02/16, 17:08

Commit message

This patch fixes a problem where setting showAccessRestrictedPages
setting in HMENU etc. did not result in the correct behavior according
to documentation at https://docs.typo3.org/typo3cms/TyposcriptReference/MenuObjects/CommonProperties/Index.html.

The patch changes the behavior caused by using `NONE` as
keyword in the setting.

Before: using the option renders `<a>Page title</a>` when page is inaccessible.

After: using the option renders `<a href="index.php?id=123">Page title</a>`
when page is not accessible.

Review

  • Code review CR +2
    • Jan Helke +2
    • Anja Leichsenring +1
  • Verified V +2
    • Jan Helke +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 2532

Show 67 earlier messages
  1. Claus Due uploaded patch set 1 11/17/16, 12:14

  2. TYPO3com voted on patch set 1 V +1 11/17/16, 12:19 Completed build in 04m 27s on Thu, 17 Nov, 01:19 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4959

  3. Kasper Ligaard commented on patch set 1 11/17/16, 18:17

    @claus: Maybe add a unit test..?
  4. Claus Due commented on patch set 1 11/17/16, 19:09

    I'll see what I can do about a unit test. I'm not sure how much of that class is currently covered and/or possible to mock. We'll know soon! :)
  5. Claus Due uploaded patch set 2 11/17/16, 19:46

  6. Claus Due commented on patch set 1 11/17/16, 19:47

    menuTypoLink is now fully covered by a new unit test. The other function however will be quite a bigger task to write a test for - I tend to wait for feedback before beginning with that one.
  7. Claus Due uploaded patch set 3 11/17/16, 19:50

  1. TYPO3com voted on patch set 2 V +1 11/17/16, 19:50 Completed build in 04m 21s on Thu, 17 Nov, 08:50 PM Test Summary: 55319 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4979

  2. Claus Due commented on patch set 1 11/17/16, 19:51

    Added some cases for the "NONE" and (int)123 cases of showAccessRestrictedPages values.
  3. TYPO3com voted on patch set 3 V +1 11/17/16, 19:55 Completed build in 04m 32s on Thu, 17 Nov, 08:55 PM Test Summary: 55331 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4980

  4. Claus Due updated the commit message in patch set 4 11/17/16, 20:11

  5. Claus Due commented on patch set 4 11/17/16, 20:12

    Changed the commit subject to reflect that this change does not just fix the special menu types but indeed all menu types.
  6. TYPO3com voted on patch set 4 V +1 11/17/16, 20:16 Completed build in 04m 36s on Thu, 17 Nov, 09:16 PM Test Summary: 55331 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4981

  7. Andreas Kienast voted on patch set 4 CR +1 11/18/16, 11:21

  8. Wouter Wolters voted on patch set 4 CR +1 11/20/16, 22:03

  9. Markus Klein commented on patch set 4 CR +1 V +1 11/25/16, 10:33

    Wow, makes totally sense. Thanks.
  10. Claus Due commented on patch set 4 11/25/16, 10:41

    Before we merge this one: RST desired? This is, after all, something that integrators may want to know about.
  11. Wouter Wolters voted on patch set 4 V +1 11/29/16, 19:48

  12. Markus Klein commented on patch set 4 11/30/16, 12:05

    I agree that an Important.rst would indeed be enlightening for integrators.
  13. Jan Helke commented on patch set 4 12/02/16, 11:20

    And I guess, we shouldn't port that back to 6.2, right?
  14. Markus Sommer voted on patch set 4 CR +1 V +1 12/02/16, 16:39

  15. Anja Leichsenring updated the commit message in patch set 5 12/02/16, 16:41

  16. TYPO3com voted on patch set 5 V +1 12/02/16, 16:45 Completed build in 04m 02s on Fri, 2 Dec, 05:45 PM Test Summary: 54191 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5357

  17. Anja Leichsenring commented on patch set 5 CR -1 12/02/16, 16:52

    rst incomming
  18. Anja Leichsenring uploaded patch set 6 12/02/16, 16:54

  19. Anja Leichsenring voted on patch set 6 CR +1 V +1 12/02/16, 16:55

  20. TYPO3com voted on patch set 6 V +1 12/02/16, 16:59 Completed build in 04m 44s on Fri, 2 Dec, 05:59 PM Test Summary: 54191 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5361

  21. Anja Leichsenring uploaded patch set 7 12/02/16, 17:00

  22. Anja Leichsenring voted on patch set 7 CR +1 V +1 12/02/16, 17:00

  23. TYPO3com voted on patch set 7 V +1 12/02/16, 17:05 Completed build in 05m 18s on Fri, 2 Dec, 06:05 PM Test Summary: 54191 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5362

  24. Jan Helke voted on patch set 7 CR +2 V +2 12/02/16, 17:08

  25. Gerrit merged patch set 7 12/02/16, 17:08