Review main Merged

50699[BUGFIX] Add check for valid directory name for TCA select fileFolder

Anja Leichsenring CR +2 V +2 Easy +35 −2 updated 11/18/16, 20:35

Commit message

If an invalid extension name is passed to a 'EXT:...' path, the
GeneralUtility::getFileAbsFileName function returns an empty string.
This results in a scan of '\' in the first place, and the resulting
error is not helpful for finding the source of the missing icons
in the TCA select box.
A check for a valid directory name and an exception in case of
failure will help the situation.

Review

  • Code review CR +2
    • Jan Helke +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2
    • Jan Helke +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1013

  1. Anja Leichsenring uploaded patch set 1 11/17/16, 16:35

  2. TYPO3com voted on patch set 1 V -1 11/17/16, 16:40 Completed build in 04m 44s on Thu, 17 Nov, 05:40 PM Test Summary: 55271 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4973

  3. Anja Leichsenring uploaded patch set 2 11/17/16, 16:52

  4. TYPO3com voted on patch set 2 V +1 11/17/16, 16:56 Completed build in 04m 18s on Thu, 17 Nov, 05:56 PM Test Summary: 55271 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4974

  5. Jan Helke voted on patch set 2 CR +1 V +1 11/18/16, 09:49

  6. Christian Kuhn commented on patch set 2 CR -1 11/18/16, 18:52

    will update

    AbstractItemProvider.php:407

    please either throw an exception from the formEngine pool here (or add a new one), but not a FAL exception. or (i guess this issue should never be caught) - throw a \RuntimeException.
  7. Christian Kuhn uploaded patch set 3 11/18/16, 18:58

  8. Christian Kuhn voted on patch set 3 CR +1 V +1 11/18/16, 19:00

  9. TYPO3com voted on patch set 3 V +1 11/18/16, 19:03 Completed build in 04m 57s on Fri, 18 Nov, 08:03 PM Test Summary: 55307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5000

  10. Wouter Wolters voted on patch set 3 CR +1 11/18/16, 19:12

  11. Jan Helke voted on patch set 3 CR +2 V +2 11/18/16, 20:22

  12. Gerrit merged patch set 3 11/18/16, 20:23

  13. Christian Kuhn commented on patch set 4 11/18/16, 20:35

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 91c149c682f8fadcc27e0a9e626f76a3a62f8838