Review main Merged

50701[BUGFIX] Update session id in user property

Helmut Hummel CR +2 V +2 Easy +1 −0 updated 11/18/16, 14:38

Commit message

The session id is also additionally stored in the
user property array in AbstractUserAuthentication.
When regenerating the session id, we must update the
session id in this user property as well, otherwise
it leads to failures in session handling (like #69763).

The workaround introduce for #69763 can stay, because
it mitigates other reasons for invalid tokens in the URL
by redirecting to the login page.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Daniel Goerz +1
    • Stephan Großberndt +1
    • Markus Klein +1
    • Andreas Kienast +1
    • Jörg Bösche +1
  • Verified V +2
    • Helmut Hummel +2
    • Markus Klein +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 910

  1. Helmut Hummel uploaded patch set 1 11/17/16, 23:57

  2. TYPO3com voted on patch set 1 V +1 11/18/16, 00:01 Completed build in 04m 05s on Fri, 18 Nov, 01:01 AM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4985

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 11/18/16, 06:32

  4. Markus Klein voted on patch set 1 CR +1 V +1 11/18/16, 07:02

  5. Stephan Großberndt voted on patch set 1 CR +1 11/18/16, 07:15

  6. Jörg Bösche voted on patch set 1 CR +1 11/18/16, 07:49

  7. Daniel Goerz voted on patch set 1 CR +1 11/18/16, 08:28

  8. Helmut Hummel voted on patch set 1 CR +2 V +2 11/18/16, 14:34

  9. Helmut Hummel commented on patch set 1 11/18/16, 14:38

    thanks for the quick reviews!
  10. Gerrit merged patch set 1 11/18/16, 14:38