Review TYPO3_6-2 Merged

50703[BUGFIX] Update session id in user property

Helmut Hummel CR +2 V +2 Easy +1 −0 updated 11/18/16, 14:39

Commit message

The session id is also additionally stored in the
user property array in AbstractUserAuthentication.
When regenerating the session id, we must update the
session id in this user property as well, otherwise
it leads to failures in session handling (like #69763).

The workaround introduce for #69763 can stay, because
it mitigates other reasons for invalid tokens in the URL
by redirecting to the login page.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Andreas Kienast +1
  • Verified V +2
    • Helmut Hummel +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 45

  1. Helmut Hummel uploaded patch set 1 11/18/16, 00:02

  2. TYPO3com voted on patch set 1 V +1 11/18/16, 00:07 Completed build in 04m 53s on Fri, 18 Nov, 01:07 AM Test Summary: 30696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC6-53

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 11/18/16, 06:33

  4. Helmut Hummel commented on patch set 1 CR +2 V +2 11/18/16, 14:39

    same code base
  5. Gerrit merged patch set 1 11/18/16, 14:39