Review TYPO3_7-6 Merged

50712[BUGFIX] Add check for valid directory name for TCA select fileFolder

Christian Kuhn CR +2 V +2 Easy +34 −2 updated 11/18/16, 21:00

Commit message

If an invalid extension name is passed to a 'EXT:...' path, the
GeneralUtility::getFileAbsFileName function returns an empty string.
This results in a scan of '\' in the first place, and the resulting
error is not helpful for finding the source of the missing icons
in the TCA select box.
A check for a valid directory name and an exception in case of
failure will help the situation.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Christian Kuhn commented on patch set 1 11/18/16, 20:35

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 11/18/16, 20:40 Completed build in 04m 15s on Fri, 18 Nov, 09:40 PM Test Summary: 2 of 20576 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-407

  3. Andreas Kienast commented on patch set 1 11/18/16, 20:46

    A Bamboo hickup? Tests run fine locally
  4. Christian Kuhn commented on patch set 1 11/18/16, 20:52

    no hickup, the 7.6 phpunit does not know about expectException() ... will fix.
  5. Christian Kuhn uploaded patch set 2 11/18/16, 20:54

  6. TYPO3com voted on patch set 2 V +1 11/18/16, 20:59 Completed build in 04m 38s on Fri, 18 Nov, 09:59 PM Test Summary: 38086 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-408

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 11/18/16, 21:00

  8. Gerrit merged patch set 2 11/18/16, 21:00

  9. Andreas Kienast commented on patch set 2 11/18/16, 21:00

    Gna, I've applied that patch to master...