Review main Merged

50716[BUGFIX] Trim input into xml2array

Anja Leichsenring CR +2 V +2 Normal +71 −1 updated 11/20/16, 12:31

Commit message

Preciding whitespace in the xml input string causes xml2array()
to fail with an error message. This whitespace is often
introduced by formatting code via IDE, so blaming the developer
only helps so far. Inserting a trim() before the input is processed
mitigates the problem.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Ralf Zimmermann +1
    • Łukasz Uznański +1
  • Verified V +2
    • Christian Kuhn +2
    • Łukasz Uznański +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 67

  1. Anja Leichsenring uploaded patch set 1 11/20/16, 08:46

  2. TYPO3com voted on patch set 1 V +1 11/20/16, 08:49 Completed build in 03m 37s on Sun, 20 Nov, 09:49 AM Test Summary: 55331 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5034

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 11/20/16, 12:23

  4. Łukasz Uznański voted on patch set 1 CR +1 V +1 11/20/16, 12:24

  5. Ralf Zimmermann voted on patch set 1 CR +1 11/20/16, 12:25

  6. Christian Kuhn voted on patch set 1 CR +2 V +2 11/20/16, 12:31

  7. Gerrit merged patch set 1 11/20/16, 12:31