Review main Merged Breaking

50722[!!!][TASK] Fluidification of EditFileController

Michael Oehlhof CR +2 V +2 Normal +66 −22 updated 12/01/16, 11:16

Commit message

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Jan Helke +1
    • Gleb Levitin +1
  • Verified V +2
    • Anja Leichsenring +2
    • Jan Helke +1
    • Gleb Levitin +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1519

  1. Michael Oehlhof uploaded patch set 1 11/21/16, 13:11

  2. Michael Oehlhof wrote 11/21/16, 13:11

    Topic set to fluidification
  3. TYPO3com voted on patch set 1 V +1 11/21/16, 13:15 Completed build in 03m 51s on Mon, 21 Nov, 02:15 PM Test Summary: 55331 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5074

  4. Jörg Bösche voted on patch set 1 CR +1 11/22/16, 06:43

  5. Markus Sommer commented on patch set 1 V -1 11/25/16, 12:54

    i got an error by edit a file. #1476107295: PHP Warning: filemtime(): stat failed for /usr/local/var/www/Apps/typo3_master/Web/typo3/sysext/backend/Resources/Private/Templates/File/EditFile.html in /Volumes/Webserver/Apps/typo3_master/typo3_src-git/vendor/typo3fluid/fluid/src/View/TemplatePaths.php line 614 (More information)
  6. Markus Sommer uploaded patch set 2 11/25/16, 13:00

  7. Markus Sommer commented on patch set 2 CR +1 V +1 11/25/16, 13:00

    It works with the correct file name. Case sensitive problem.
  8. TYPO3com voted on patch set 2 V +1 11/25/16, 13:04 Completed build in 04m 18s on Fri, 25 Nov, 02:04 PM Test Summary: 55589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5126

  9. Jörg Bösche voted on patch set 2 CR +1 11/27/16, 22:00

  10. Georg Ringer commented on patch set 2 CR -1 11/29/16, 04:08

    EditFileController.php:211

    This is a breaking change! The hook will get now a different HTML, please write a rst for that!
  11. Michael Oehlhof uploaded patch set 3 11/29/16, 09:01

  12. TYPO3com voted on patch set 3 V +1 11/29/16, 09:05 Completed build in 03m 59s on Tue, 29 Nov, 10:05 AM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5185

  13. Gleb Levitin voted on patch set 3 CR +1 V +1 12/01/16, 11:05

  14. Andreas Kienast updated the commit message in patch set 4 12/01/16, 11:06

  15. Gleb Levitin voted on patch set 4 CR +1 V +1 12/01/16, 11:10

  16. TYPO3com voted on patch set 4 V +1 12/01/16, 11:12 Completed build in 05m 56s on Thu, 1 Dec, 12:12 PM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5229

  17. Jan Helke voted on patch set 4 CR +1 V +1 12/01/16, 11:14

  18. Anja Leichsenring voted on patch set 4 CR +2 V +2 12/01/16, 11:16

  19. Gerrit merged patch set 4 12/01/16, 11:16