50722[!!!][TASK] Fluidification of EditFileController
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Jan Helke +1
- Gleb Levitin +1
-
Verified V +2
- Anja Leichsenring +2
- Jan Helke +1
- Gleb Levitin +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1519
-
Michael Oehlhof uploaded patch set 1 11/21/16, 13:11
-
Michael Oehlhof wrote 11/21/16, 13:11
Topic set to fluidification -
TYPO3com voted on patch set 1 V +1 11/21/16, 13:15 Completed build in 03m 51s on Mon, 21 Nov, 02:15 PM Test Summary: 55331 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5074
-
Jörg Bösche voted on patch set 1 CR +1 11/22/16, 06:43
-
Markus Sommer commented on patch set 1 V -1 11/25/16, 12:54
i got an error by edit a file. #1476107295: PHP Warning: filemtime(): stat failed for /usr/local/var/www/Apps/typo3_master/Web/typo3/sysext/backend/Resources/Private/Templates/File/EditFile.html in /Volumes/Webserver/Apps/typo3_master/typo3_src-git/vendor/typo3fluid/fluid/src/View/TemplatePaths.php line 614 (More information) -
Markus Sommer uploaded patch set 2 11/25/16, 13:00
-
Markus Sommer commented on patch set 2 CR +1 V +1 11/25/16, 13:00
It works with the correct file name. Case sensitive problem. -
TYPO3com voted on patch set 2 V +1 11/25/16, 13:04 Completed build in 04m 18s on Fri, 25 Nov, 02:04 PM Test Summary: 55589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5126
-
Jörg Bösche voted on patch set 2 CR +1 11/27/16, 22:00
-
Georg Ringer commented on patch set 2 CR -1 11/29/16, 04:08
EditFileController.php:211This is a breaking change! The hook will get now a different HTML, please write a rst for that! -
Michael Oehlhof uploaded patch set 3 11/29/16, 09:01
-
TYPO3com voted on patch set 3 V +1 11/29/16, 09:05 Completed build in 03m 59s on Tue, 29 Nov, 10:05 AM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5185
-
Gleb Levitin voted on patch set 3 CR +1 V +1 12/01/16, 11:05
-
Andreas Kienast updated the commit message in patch set 4 12/01/16, 11:06
-
Gleb Levitin voted on patch set 4 CR +1 V +1 12/01/16, 11:10
-
TYPO3com voted on patch set 4 V +1 12/01/16, 11:12 Completed build in 05m 56s on Thu, 1 Dec, 12:12 PM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5229
-
Jan Helke voted on patch set 4 CR +1 V +1 12/01/16, 11:14
-
Anja Leichsenring voted on patch set 4 CR +2 V +2 12/01/16, 11:16
-
Gerrit merged patch set 4 12/01/16, 11:16