Review main Merged

50726[TASK] Fluidification of ReplaceFileController

Michael Oehlhof CR +2 V +2 Normal +53 −50 updated 12/02/16, 10:00

Commit message

Review

  • Code review CR +2
    • Jan Helke +2
    • Alexander Rothmund +1
    • Alexander Stehlik +1
    • Gianluigi Martino +1
  • Verified V +2
    • Jan Helke +2
    • Alexander Rothmund +1
    • Alexander Stehlik +1
    • Gianluigi Martino +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1214

  1. Michael Oehlhof uploaded patch set 1 11/21/16, 19:11

  2. Michael Oehlhof wrote 11/21/16, 19:12

    Topic set to fluidification
  3. TYPO3com voted on patch set 1 V +1 11/21/16, 19:15 Completed build in 04m 05s on Mon, 21 Nov, 08:15 PM Test Summary: 55331 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5092

  4. Jörg Bösche voted on patch set 1 CR +1 11/22/16, 06:40

  5. Markus Sommer voted on patch set 1 CR +1 11/27/16, 10:01

  6. Alexander Stehlik commented on patch set 1 V -1 12/01/16, 12:17

    ReplaceFile.html:21

    The backslashes are invalid and cause JS errors.
  7. Alexander Stehlik commented on patch set 1 12/01/16, 12:21

    I'll provide a new patch
  8. Alexander Stehlik uploaded patch set 2 12/01/16, 12:28

  9. Alexander Stehlik commented on patch set 2 CR +1 V +1 12/01/16, 12:33

    Rebased, fixed JS quoting, works fine now.
  10. TYPO3com voted on patch set 2 V +1 12/01/16, 12:33 Completed build in 04m 58s on Thu, 1 Dec, 01:33 PM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5237

  11. Gianluigi Martino voted on patch set 2 CR +1 V +1 12/01/16, 15:24

  12. Alexander Rothmund voted on patch set 2 CR +1 V +1 12/01/16, 17:16

  13. Jan Helke voted on patch set 2 CR +2 V +2 12/02/16, 10:00

  14. Gerrit merged patch set 2 12/02/16, 10:00