Review TYPO3_6-2 Merged

50738[SECURITY] Disallow invalid encoding in GeneralUtility::validPathStr

Oliver Hader CR +2 V +2 Easy +3 −2 updated 11/22/16, 10:18

Commit message

Directory names, which have an invalid UTF encoding,
cause the preg_match() to return false.
To avoid that the complete statement in GeneralUtility::validPathStr()
returns true in this case, a strict comparison against 0 is added,
so that we ensure that strings with invalid encodings are rejected
by this API method.

As a consequence UTF-16 encoded path names are rejected as well, if the
system / file system does not support them.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2

Issues 1

Files 3

Review log 34

  1. Oliver Hader uploaded patch set 1 11/22/16, 10:09

  2. Gerrit merged patch set 1 11/22/16, 10:09

  3. Oliver Hader commented on patch set 1 CR +2 V +2 11/22/16, 10:09

    Auto-approved
  4. TYPO3com commented on patch set 1 11/22/16, 10:18 Completed build in 09m 32s on Tue, 22 Nov, 11:18 AM Test Summary: 30876 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC6-58