Review main Merged

50752[TASK] Remove has-call to caching framework in explodeSoftRefParserList

Wouter Wolters CR +2 V +2 Easy +8 −7 updated 12/01/16, 18:53

Commit message

No need to call has on the caching framework in the function
explodeSoftRefParserList. Furthermore we do not need to store false
to the runtime cache if parseList is an empty string.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Claus Due +1
    • Oliver Klee +1
    • Markus Klein +1
    • Anja Leichsenring +1
    • Robert van Kammen +1
    • Jörg Bösche +1
  • Verified V +2
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1517

  1. Wouter Wolters uploaded patch set 1 11/22/16, 22:24

  2. TYPO3com voted on patch set 1 V +1 11/22/16, 22:27 Completed build in 03m 27s on Tue, 22 Nov, 11:27 PM Test Summary: 55589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5102

  3. Claus Due commented on patch set 1 11/22/16, 23:03

    BackendUtility.php:4120

    Should probably be a !== false comparison. Just for consistency since that seems to be the way we check cache returns in most other places.
  4. Wouter Wolters commented on patch set 2 11/23/16, 10:27

    Published edit on patch set 1.
  5. TYPO3com voted on patch set 2 V +1 11/23/16, 10:31 Completed build in 03m 51s on Wed, 23 Nov, 11:31 AM Test Summary: 55589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5103

  6. Claus Due voted on patch set 2 CR +1 11/23/16, 10:34

  7. Markus Klein voted on patch set 2 CR +1 11/23/16, 10:40

  8. Robert van Kammen voted on patch set 2 CR +1 11/24/16, 14:10

  9. Claus Due commented on patch set 2 11/26/16, 13:44

    Backported for LTS as https://review.typo3.org/#/c/50783/. Wouter, if you don't mind, please update the topic to "performance" (I'm using this one to group all the patches I keep close track of in nov/dec).
  10. Wouter Wolters wrote 11/26/16, 17:16

    Topic set to performance
  11. Oliver Klee voted on patch set 2 CR +1 11/26/16, 17:50

  12. Jörg Bösche voted on patch set 2 CR +1 11/27/16, 21:59

  13. Anja Leichsenring voted on patch set 2 CR +1 V +1 12/01/16, 18:40

  14. Andreas Kienast commented on patch set 2 CR -1 12/01/16, 18:48

    On it
  15. Andreas Kienast commented on patch set 2 12/01/16, 18:49

    BackendUtility.php:4113

    Are you sure about this? An empty parserList is NULL here
  16. Andreas Kienast commented on patch set 2 CR +2 V +2 12/01/16, 18:53

    BackendUtility.php:4113 Reply

    Never mind, it's not part of that patch
  17. Gerrit merged patch set 2 12/01/16, 18:53