Review main Merged

50753[BUGFIX] Show errors on ajax file actions

Alexander Opitz CR +2 V +2 Easy +32 −2 updated 12/01/16, 15:58

Commit message

Respond with status code 500 on ajax file actions, so JS can differ
between success and failure.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Manuel Glauser +1
    • Gleb Levitin +1
    • Gianluigi Martino +1
  • Verified V +2
    • Anja Leichsenring +2
    • Manuel Glauser +1
    • Gianluigi Martino +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 1214

  1. Alexander Opitz uploaded patch set 1 11/23/16, 11:46

  2. TYPO3com voted on patch set 1 V +1 11/23/16, 11:50 Completed build in 04m 12s on Wed, 23 Nov, 12:50 PM Test Summary: 55589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5104

  3. Manuel Glauser voted on patch set 1 CR +1 V +1 12/01/16, 13:54

  4. Gianluigi Martino voted on patch set 1 CR +1 V +1 12/01/16, 13:57

  5. Gleb Levitin voted on patch set 1 CR +1 12/01/16, 14:46

  6. Anja Leichsenring commented on patch set 1 CR -1 12/01/16, 15:24

    on it
  7. Anja Leichsenring uploaded patch set 2 12/01/16, 15:35

  8. TYPO3com voted on patch set 2 V +1 12/01/16, 15:39 Completed build in 03m 52s on Thu, 1 Dec, 04:39 PM Test Summary: 54089 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5256

  9. Gleb Levitin voted on patch set 2 CR +1 12/01/16, 15:41

  10. Gianluigi Martino commented on patch set 2 V -1 12/01/16, 15:48

    conflict with unit tests in 7.6 / master seems to be ok..
  11. Manuel Glauser commented on patch set 2 CR +1 V +1 12/01/16, 15:54

    Fails to automatically merge with current 7.6 branch, though => needs backport?
  12. Gianluigi Martino voted on patch set 2 CR +1 V +1 12/01/16, 15:57

  13. Anja Leichsenring voted on patch set 2 CR +2 V +2 12/01/16, 15:58

  14. Gerrit merged patch set 2 12/01/16, 15:58