Review TYPO3_7-6 Abandoned

50754[BUGFIX] #78775 ProgressHelper, 7.6.13, Symfony 3

Jakob Berlin CR 0 V 0 Easy +15 −15 updated 11/23/16, 12:50

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 68

  1. Jakob Berlin uploaded patch set 1 11/23/16, 12:01

  2. TYPO3com voted on patch set 1 V +1 11/23/16, 12:04 Completed build in 03m 22s on Wed, 23 Nov, 01:04 PM Test Summary: 38266 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-428

  3. Stefan Neufeind updated the commit message in patch set 2 11/23/16, 12:06

  4. TYPO3com voted on patch set 2 V +1 11/23/16, 12:09 Completed build in 03m 17s on Wed, 23 Nov, 01:09 PM Test Summary: 38266 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-429

  5. Helmut Hummel commented on patch set 2 CR -2 11/23/16, 12:20

    Unfortunately that is an API change, that cannot go into a released TYPO3 version. Besides that, I assume, that more things need to be changed to be symfony/console 3.0 ready We need to just revert the composer.json change that was unfortunately made here: https://review.typo3.org/#/c/50629
  6. Helmut Hummel commented on patch set 2 11/23/16, 12:21

    here are the changes that would be required: https://review.typo3.org/#/c/46505
  7. Helmut Hummel commented on patch set 2 11/23/16, 12:23

    these are the composer.json changes we need to end up with: https://review.typo3.org/#/c/48064
  8. Stefan Neufeind abandoned the change 11/23/16, 12:50

    Rebased 48064 and thus I abandon this change here. I agree the other patch imho is the way to handle it (have 2.7 or later but below 3.0). We can't patch 7.6 to make it 3.0-compatible.