Review main Merged

50767[BUGFIX] Fix bug in linkhandler when file is selected

Sascha Egerer CR +2 V +2 Easy +3 −3 updated 12/03/16, 11:57

Commit message

Selecting a file an the RTE linkhandler works but reopening
the linkhandler ends with a fatal error as a file object
is passed instead of string.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Jan Helke +2
    • Markus Sommer +1
    • Tymoteusz Motylewski +1
  • Verified V +2
    • Wouter Wolters +2
    • Jan Helke +2
    • Markus Sommer +1
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1617

  1. Sascha Egerer uploaded patch set 1 11/24/16, 14:21

  2. TYPO3com voted on patch set 1 V +1 11/24/16, 14:25 Completed build in 04m 31s on Thu, 24 Nov, 03:25 PM Test Summary: 55589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5111

  3. Tymoteusz Motylewski commented on patch set 1 11/24/16, 15:38

    can not reproduce it (on current master, RTE in demo mode). What I did: 1. edit CE text + media 2. select text 3. click on the icon opening the linkhandler 4. select a file 5. close the linkhandler 6. click on the icon opening linkhanlder again 7. wizard was opened correctly
  4. Sascha Egerer commented on patch set 1 11/24/16, 15:41

    I've the same problem - can only reproduce it on our production system. Don't know if it has something todo with php error log settings or something like that as on my local system it looks like the fatal error is catched by a try catch block. But not sure about it
  5. Tymoteusz Motylewski commented on patch set 1 11/24/16, 15:49

    that's right "PHP Catchable Fatal Error: Object of class TYPO3\CMS\Core\Resource\File could not be converted to string in typo3/sysext/core/Classes/Resource/ResourceFactory.php line 470
  6. Tymoteusz Motylewski commented on patch set 1 11/24/16, 15:51

    It's caught in typo3/sysext/recordlist/Classes/LinkHandler/FileLinkHandler.php line 287
  7. Tymoteusz Motylewski voted on patch set 1 CR +1 V +1 11/24/16, 15:54

  8. Markus Sommer commented on patch set 1 V -1 11/25/16, 12:18

    Sorry i can not reproduce this. No exception and no notice. with E_ALL ^ E_NOTICE Have you a custom "linkhandler" config?
  9. Tymoteusz Motylewski commented on patch set 1 11/25/16, 13:01

    @markus can you place a breakpoint or log the exeception in typo3/sysext/recordlist/Classes/LinkHandler/FileLinkHandler.php line 287 ? This exception is caught that's why you can't see it, however calling these method with invalid parameters should be fixed. That's why this patch is OK in my POV. @Sascha, can you check the configured error handler on your production?
  10. Sascha Egerer commented on patch set 1 11/26/16, 10:54

    Sorry I'm in vacation now and not able to investigate further. But this change should make sense even by reading...
  11. Wouter Wolters voted on patch set 1 CR +1 V +1 11/29/16, 20:45

  12. Markus Klein commented on patch set 1 11/30/16, 12:06

    does that affect 7.6 as well?
  13. Wouter Wolters commented on patch set 1 11/30/16, 12:09

  14. Markus Sommer commented on patch set 1 CR +1 V +1 12/03/16, 11:55

    Oki this is a good point :) perfect
  15. Wouter Wolters voted on patch set 1 CR +2 V +2 12/03/16, 11:57

  16. Jan Helke voted on patch set 1 CR +2 V +2 12/03/16, 11:57

  17. Gerrit merged patch set 1 12/03/16, 11:57