5077[TASK] Refactor code of new form system extension
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
-
Verified V +2
- Oliver Hader +2
Issues 1
Files 160
- typo3/sysext/form/Classes/Controller/Form.php+9 −14
- typo3/sysext/form/Classes/Controller/Wizard.php+12 −17
- typo3/sysext/form/Classes/Domain/Factory/JsonToTyposcript.php+49 −53
- typo3/sysext/form/Classes/Domain/Factory/Typoscript.php+60 −41
- typo3/sysext/form/Classes/Domain/Factory/TyposcriptToJson.php+15 −16
- typo3/sysext/form/Classes/Domain/Model/Additional/Abstract.php+7 −1
- typo3/sysext/form/Classes/Domain/Model/Additional/Additional.php+4 −16
- typo3/sysext/form/Classes/Domain/Model/Additional/Error.php+2 −14
- typo3/sysext/form/Classes/Domain/Model/Additional/Interface.phpdeleted+0 −41
- typo3/sysext/form/Classes/Domain/Model/Additional/Label.php+1 −12
- typo3/sysext/form/Classes/Domain/Model/Additional/Legend.php+1 −13
- typo3/sysext/form/Classes/Domain/Model/Additional/Mandatory.php+2 −14
- typo3/sysext/form/Classes/Domain/Model/Attributes/Abstract.php+7 −0
- typo3/sysext/form/Classes/Domain/Model/Attributes/Accept.php+2 −14
- typo3/sysext/form/Classes/Domain/Model/Attributes/Acceptcharset.php+2 −14
- typo3/sysext/form/Classes/Domain/Model/Attributes/Accesskey.php+2 −14
- typo3/sysext/form/Classes/Domain/Model/Attributes/Action.php+3 −15
- typo3/sysext/form/Classes/Domain/Model/Attributes/Alt.php+2 −14
- typo3/sysext/form/Classes/Domain/Model/Attributes/Attributes.php+4 −9
- typo3/sysext/form/Classes/Domain/Model/Attributes/Checked.php+3 −15
Show 140 more files
- typo3/sysext/form/Classes/Domain/Model/Attributes/Class.php+2 −14
- typo3/sysext/form/Classes/Domain/Model/Attributes/Cols.php+3 −15
- typo3/sysext/form/Classes/Domain/Model/Attributes/Dir.php+3 −15
- typo3/sysext/form/Classes/Domain/Model/Attributes/Disabled.php+3 −15
- typo3/sysext/form/Classes/Domain/Model/Attributes/Enctype.php+3 −15
- typo3/sysext/form/Classes/Domain/Model/Attributes/Id.php+8 −20
- typo3/sysext/form/Classes/Domain/Model/Attributes/Interface.phpdeleted+0 −41
- typo3/sysext/form/Classes/Domain/Model/Attributes/Label.php+1 −13
- typo3/sysext/form/Classes/Domain/Model/Attributes/Lang.php+2 −14
- typo3/sysext/form/Classes/Domain/Model/Attributes/Maxlength.php+3 −15
- typo3/sysext/form/Classes/Domain/Model/Attributes/Method.php+2 −14
- typo3/sysext/form/Classes/Domain/Model/Attributes/Multiple.php+3 −15
- typo3/sysext/form/Classes/Domain/Model/Attributes/Name.php+5 −16
- typo3/sysext/form/Classes/Domain/Model/Attributes/Readonly.php+3 −15
- typo3/sysext/form/Classes/Domain/Model/Attributes/Rows.php+3 −15
- typo3/sysext/form/Classes/Domain/Model/Attributes/Selected.php+3 −15
- typo3/sysext/form/Classes/Domain/Model/Attributes/Size.php+3 −15
- typo3/sysext/form/Classes/Domain/Model/Attributes/Src.php+2 −14
- typo3/sysext/form/Classes/Domain/Model/Attributes/Style.php+2 −14
- typo3/sysext/form/Classes/Domain/Model/Attributes/Tabindex.php+3 −15
- typo3/sysext/form/Classes/Domain/Model/Attributes/Title.php+2 −14
- typo3/sysext/form/Classes/Domain/Model/Attributes/Type.php+6 −15
- typo3/sysext/form/Classes/Domain/Model/Attributes/Value.php+2 −14
- typo3/sysext/form/Classes/Domain/Model/Element/Abstract.php+39 −29
- typo3/sysext/form/Classes/Domain/Model/Element/Button.php+3 −12
- typo3/sysext/form/Classes/Domain/Model/Element/Checkbox.php+10 −21
- typo3/sysext/form/Classes/Domain/Model/Element/Checkboxgroup.php+3 −15
- typo3/sysext/form/Classes/Domain/Model/Element/Container.php+3 −12
- typo3/sysext/form/Classes/Domain/Model/Element/Content.php+18 −16
- typo3/sysext/form/Classes/Domain/Model/Element/Fieldset.php+0 −11
- typo3/sysext/form/Classes/Domain/Model/Element/Fileupload.php+0 −10
- typo3/sysext/form/Classes/Domain/Model/Element/Hidden.php+2 −13
- typo3/sysext/form/Classes/Domain/Model/Element/Imagebutton.php+0 −10
- typo3/sysext/form/Classes/Domain/Model/Element/Optgroup.php+7 −25
- typo3/sysext/form/Classes/Domain/Model/Element/Option.php+11 −23
- typo3/sysext/form/Classes/Domain/Model/Element/Password.php+2 −13
- typo3/sysext/form/Classes/Domain/Model/Element/Radio.php+4 −15
- typo3/sysext/form/Classes/Domain/Model/Element/Radiogroup.php+2 −14
- typo3/sysext/form/Classes/Domain/Model/Element/Reset.php+2 −12
- typo3/sysext/form/Classes/Domain/Model/Element/Select.php+6 −16
- typo3/sysext/form/Classes/Domain/Model/Element/Submit.php+3 −12
- typo3/sysext/form/Classes/Domain/Model/Element/Textarea.php+2 −13
- typo3/sysext/form/Classes/Domain/Model/Element/Textline.php+2 −13
- typo3/sysext/form/Classes/Domain/Model/JSON/Button.php+0 −9
- typo3/sysext/form/Classes/Domain/Model/JSON/Checkbox.php+0 −9
- typo3/sysext/form/Classes/Domain/Model/JSON/Checkboxgroup.php+4 −13
- typo3/sysext/form/Classes/Domain/Model/JSON/Container.php+2 −11
- typo3/sysext/form/Classes/Domain/Model/JSON/Element.php+7 −15
- typo3/sysext/form/Classes/Domain/Model/JSON/Fieldset.php+2 −12
- typo3/sysext/form/Classes/Domain/Model/JSON/Form.php+5 −15
- typo3/sysext/form/Classes/Domain/Model/JSON/Header.php+2 −12
- typo3/sysext/form/Classes/Domain/Model/JSON/Hidden.php+0 −9
- typo3/sysext/form/Classes/Domain/Model/JSON/Name.php+3 −13
- typo3/sysext/form/Classes/Domain/Model/JSON/Password.php+0 −9
- typo3/sysext/form/Classes/Domain/Model/JSON/Radio.php+0 −9
- typo3/sysext/form/Classes/Domain/Model/JSON/Radiogroup.php+4 −14
- typo3/sysext/form/Classes/Domain/Model/JSON/Reset.php+0 −9
- typo3/sysext/form/Classes/Domain/Model/JSON/Select.php+3 −13
- typo3/sysext/form/Classes/Domain/Model/JSON/Submit.php+0 −9
- typo3/sysext/form/Classes/Domain/Model/JSON/Textarea.php+0 −9
- typo3/sysext/form/Classes/Domain/Model/JSON/Textline.php+0 −9
- typo3/sysext/form/Classes/Domain/Model/Content.php+0 −10
- typo3/sysext/form/Classes/Domain/Model/Form.php+7 −15
- typo3/sysext/form/Classes/Domain/Repository/Content.php+4 −14
- typo3/sysext/form/Classes/Exception/General.phpdeleted+0 −35
- typo3/sysext/form/Classes/Exception/Loader.phpdeleted+0 −35
- typo3/sysext/form/Classes/System/Elementcounter/Elementcounter.php+0 −8
- typo3/sysext/form/Classes/System/Filter/Alphabetic.php+0 −1
- typo3/sysext/form/Classes/System/Filter/Alphanumeric.php+0 −1
- typo3/sysext/form/Classes/System/Filter/Currency.php+8 −9
- typo3/sysext/form/Classes/System/Filter/Digit.php+0 −9
- typo3/sysext/form/Classes/System/Filter/Filter.php+33 −26
- typo3/sysext/form/Classes/System/Filter/Integer.php+0 −9
- typo3/sysext/form/Classes/System/Filter/Interface.php+1 −1
- typo3/sysext/form/Classes/System/Filter/Lowercase.php+0 −9
- typo3/sysext/form/Classes/System/Filter/Regexp.php+1 −2
- typo3/sysext/form/Classes/System/Filter/Removexss.php+0 −10
- typo3/sysext/form/Classes/System/Filter/Stripnewlines.php+0 −9
- typo3/sysext/form/Classes/System/Filter/Titlecase.php+0 −9
- typo3/sysext/form/Classes/System/Filter/Trim.php+1 −2
- typo3/sysext/form/Classes/System/Filter/Uppercase.php+0 −9
- typo3/sysext/form/Classes/System/Layout/Layout.php+8 −9
- typo3/sysext/form/Classes/System/Loader/Loader.phpdeleted+0 −66
- typo3/sysext/form/Classes/System/Localization/Localization.php+2 −3
- typo3/sysext/form/Classes/System/Postprocessor/Mail.php+36 −9
- typo3/sysext/form/Classes/System/Postprocessor/Postprocessor.php+11 −10
- typo3/sysext/form/Classes/System/Request/Request.php+10 −20
- typo3/sysext/form/Classes/System/Validate/Abstract.php+10 −9
- typo3/sysext/form/Classes/System/Validate/Alphabetic.php+4 −6
- typo3/sysext/form/Classes/System/Validate/Alphanumeric.php+4 −6
- typo3/sysext/form/Classes/System/Validate/Between.php+8 −9
- typo3/sysext/form/Classes/System/Validate/Date.php+2 −91
- typo3/sysext/form/Classes/System/Validate/Digit.php+1 −2
- typo3/sysext/form/Classes/System/Validate/Email.php+2 −3
- typo3/sysext/form/Classes/System/Validate/Equals.php+3 −4
- typo3/sysext/form/Classes/System/Validate/Fileallowedtypes.php+2 −3
- typo3/sysext/form/Classes/System/Validate/Filemaximumsize.php+2 −3
- typo3/sysext/form/Classes/System/Validate/Fileminimumsize.php+2 −3
- typo3/sysext/form/Classes/System/Validate/Float.php+2 −3
- typo3/sysext/form/Classes/System/Validate/Greaterthan.php+2 −3
- typo3/sysext/form/Classes/System/Validate/Inarray.php+2 −3
- typo3/sysext/form/Classes/System/Validate/Integer.php+1 −2
- typo3/sysext/form/Classes/System/Validate/Ip.php+2 −3
- typo3/sysext/form/Classes/System/Validate/Length.php+7 −8
- typo3/sysext/form/Classes/System/Validate/Lessthan.php+2 −3
- typo3/sysext/form/Classes/System/Validate/Regexp.php+2 −3
- typo3/sysext/form/Classes/System/Validate/Required.php+2 −3
- typo3/sysext/form/Classes/System/Validate/Uri.php+2 −3
- typo3/sysext/form/Classes/System/Validate/Validate.php+6 −6
- typo3/sysext/form/Classes/View/Confirmation/Additional/Additional.php+1 −1
- typo3/sysext/form/Classes/View/Confirmation/Element/Abstract.php+37 −52
- typo3/sysext/form/Classes/View/Confirmation/Element/Container.php+4 −6
- typo3/sysext/form/Classes/View/Confirmation/Confirmation.php+2 −2
- typo3/sysext/form/Classes/View/Form/Additional/Additional.php+1 −1
- typo3/sysext/form/Classes/View/Form/Element/Abstract.php+27 −44
- typo3/sysext/form/Classes/View/Form/Element/Container.php+8 −6
- typo3/sysext/form/Classes/View/Mail/Html/Additional/Additional.php+1 −1
- typo3/sysext/form/Classes/View/Mail/Html/Element/Abstract.php+32 −51
- typo3/sysext/form/Classes/View/Mail/Html/Element/Container.php+4 −6
- typo3/sysext/form/Classes/View/Mail/Plain/Element/Abstract.php+13 −20
- typo3/sysext/form/Classes/View/Mail/Plain/Element/Checkbox.php+11 −3
- typo3/sysext/form/Classes/View/Mail/Plain/Element/Checkboxgroup.php+5 −2
- typo3/sysext/form/Classes/View/Mail/Plain/Element/Container.php+14 −11
- typo3/sysext/form/Classes/View/Mail/Plain/Element/Fieldset.php+4 −1
- typo3/sysext/form/Classes/View/Mail/Plain/Element/Fileupload.php+10 −1
- typo3/sysext/form/Classes/View/Mail/Plain/Element/Hidden.php+7 −1
- typo3/sysext/form/Classes/View/Mail/Plain/Element/Optgroup.php+4 −1
- typo3/sysext/form/Classes/View/Mail/Plain/Element/Option.php+8 −2
- typo3/sysext/form/Classes/View/Mail/Plain/Element/Radio.php+7 −1
- typo3/sysext/form/Classes/View/Mail/Plain/Element/Radiogroup.php+4 −1
- typo3/sysext/form/Classes/View/Mail/Plain/Element/Select.php+10 −1
- typo3/sysext/form/Classes/View/Mail/Plain/Element/Textarea.php+7 −1
- typo3/sysext/form/Classes/View/Mail/Plain/Element/Textline.php+10 −1
- typo3/sysext/form/Classes/View/Mail/Mail.php+5 −4
- typo3/sysext/form/Classes/View/Wizard/Abstract.phpnew+72 −0
- typo3/sysext/form/Classes/View/Wizard/Load.php+2 −30
- typo3/sysext/form/Classes/View/Wizard/Save.php+1 −28
- typo3/sysext/form/Classes/View/Wizard/Wizard.php+16 −32
- typo3/sysext/form/Classes/Common.php+19 −2
- typo3/sysext/form/ext_autoload.php+2 −6
Review log 6
-
Oliver Hader uploaded patch set 2 09/19/11, 22:28
-
Oliver Hader commented on patch set 2 V 0 09/19/11, 22:28
by team member; Looks good to me, approved -
Mr. Jenkins commented on patch set 1 09/19/11, 22:28
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1903/ : SUCCESS -
Mr. Jenkins commented on patch set 2 09/19/11, 22:28
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1914/ : SUCCESS -
Oliver Hader merged patch set 2 09/19/11, 22:28