Review TYPO3_7-6 Merged

50775[BUGFIX] Make showAccessRestrictedPages work

Claus Due CR +2 V +2 Hard +270 −2 updated 12/03/16, 09:57

Commit message

This patch fixes a problem where setting showAccessRestrictedPages
setting in HMENU etc. did not result in the correct behavior according
to documentation at https://docs.typo3.org/typo3cms/TyposcriptReference/MenuObjects/CommonProperties/Index.html.

The patch changes the behavior caused by using `NONE` as
keyword in the setting.

Before: using the option renders `<a>Page title</a>` when page is inaccessible.

After: using the option renders `<a href="index.php?id=123">Page title</a>`
when page is not accessible.

Review

  • Code review CR +2
    • Jan Helke +2
  • Verified V +2
    • Jan Helke +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 58

  1. Claus Due uploaded patch set 1 11/25/16, 10:19

  2. TYPO3com voted on patch set 1 V +1 11/25/16, 10:23 Completed build in 04m 30s on Fri, 25 Nov, 11:23 AM Test Summary: 38310 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-439

  3. Anja Leichsenring updated the commit message in patch set 2 12/02/16, 16:55

  4. Anja Leichsenring uploaded patch set 3 12/02/16, 16:59

  5. TYPO3com voted on patch set 2 V +1 12/02/16, 17:02 Completed build in 06m 12s on Fri, 2 Dec, 06:02 PM Test Summary: 38318 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-484

  6. TYPO3com voted on patch set 3 V +1 12/02/16, 17:06 Completed build in 06m 42s on Fri, 2 Dec, 06:06 PM Test Summary: 38318 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-485

  7. Jan Helke voted on patch set 3 CR +2 V +2 12/02/16, 17:09

  8. Gerrit merged patch set 3 12/03/16, 09:57