Review TYPO3_7-6 Merged

50778[BUGFIX] Avoid RTE context menu collapse to arrows only

Claus Due CR +2 V +2 Easy +3 −1 updated 12/01/16, 20:53

Commit message

Solves an issue in Chrome where calculating the height of
the editor window returns zero. Solved by hardcoding a
minimum context menu height of 150 pixels; applied via
Math.max()'ing the resolved height and 150.

Review

  • Code review CR +2
    • Wouter Wolters +2
  • Verified V +2
    • Wouter Wolters +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Claus Due uploaded patch set 1 11/25/16, 11:57

  2. TYPO3com voted on patch set 1 V +1 11/25/16, 12:00 Completed build in 03m 36s on Fri, 25 Nov, 01:00 PM Test Summary: 38266 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-441

  3. Claus Due commented on patch set 1 11/25/16, 12:07

    Added the code comment from LTS counterpart patch.
  4. Wouter Wolters voted on patch set 1 CR +2 V +2 12/01/16, 20:53

  5. Gerrit merged patch set 1 12/01/16, 20:53