Review main Merged

50779[BUGFIX] Avoid RTE context menu collapse to arrows only

Claus Due CR +2 V +2 Easy +3 −1 updated 12/01/16, 20:52

Commit message

Solves an issue in Chrome where calculating the height of
the editor window returns zero. Solved by hardcoding a
minimum context menu height of 150 pixels; applied via
Math.max()'ing the resolved height and 150.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Georg Ringer +1
    • Markus Sommer +1
    • Gianluigi Martino +1
  • Verified V +2
    • Wouter Wolters +2
    • Georg Ringer +1
    • Markus Sommer +1
    • Gianluigi Martino +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Claus Due uploaded patch set 1 11/25/16, 12:01

  2. TYPO3com voted on patch set 1 V +1 11/25/16, 12:05 Completed build in 04m 15s on Fri, 25 Nov, 01:05 PM Test Summary: 55589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5124

  3. Claus Due uploaded patch set 2 11/25/16, 12:07

  4. Claus Due commented on patch set 2 11/25/16, 12:08

    Added the code comment from LTS counterpart patch.
  5. TYPO3com voted on patch set 2 V +1 11/25/16, 12:11 Completed build in 04m 18s on Fri, 25 Nov, 01:11 PM Test Summary: 55589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5125

  6. Wouter Wolters voted on patch set 2 CR +1 11/29/16, 19:50

  7. Georg Ringer voted on patch set 2 CR +1 V +1 11/30/16, 06:21

  8. Gianluigi Martino voted on patch set 2 CR +1 V +1 12/01/16, 12:03

  9. Markus Sommer commented on patch set 2 CR +1 V +1 12/01/16, 12:24

    It works :)
  10. Wouter Wolters voted on patch set 2 CR +2 V +2 12/01/16, 20:52

  11. Gerrit merged patch set 2 12/01/16, 20:52