Review TYPO3_7-6 Merged

50780[BUGFIX] Fix incorrect position of RTE context menu

Claus Due CR +2 V +2 Easy +2 −2 updated 12/01/16, 10:43

Commit message

Fixes the position of the context menu to the cursor,
preventing it from being displayed outside of the
RTE frame.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Manuel Glauser +1
  • Verified V +2
    • Anja Leichsenring +2
    • Manuel Glauser +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1113

  1. Claus Due uploaded patch set 1 11/25/16, 13:16

  2. TYPO3com voted on patch set 1 V +1 11/25/16, 13:19 Completed build in 03m 30s on Fri, 25 Nov, 02:19 PM Test Summary: 38266 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-442

  3. Riccardo De Contardi commented on patch set 1 V -1 11/25/16, 19:58

    not working with latest master; To make it work, I added position:relative to the <body> inside the <iframe id="typo3-contentIframe">, but I don't know if there are drawbacks.
  4. Claus Due commented on patch set 1 11/26/16, 01:21

    @Riccardo this means the patch for the master branch has to be different (and you are more than welcome to create that one) - but this patch is for LTS and should solve the issue on there. It doesn't have to apply 1:1 to master branch, especially since the ContextMenu.js file is quite different there.
  5. Riccardo De Contardi commented on patch set 1 11/26/16, 15:42

    @Claus the review says "Releases: master, 7.6" so I tested it on Master, too :)
  6. Claus Due commented on patch set 1 11/29/16, 13:18

    Will remove the "master" from releases tag ;)
  7. Claus Due updated the commit message in patch set 2 11/29/16, 13:21

  8. TYPO3com voted on patch set 2 V +1 11/29/16, 13:26 Completed build in 05m 32s on Tue, 29 Nov, 02:26 PM Test Summary: 38266 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-449

  9. Gianluigi Martino voted on patch set 2 V -1 12/01/16, 09:40

  10. Manuel Glauser voted on patch set 2 CR +1 V +1 12/01/16, 10:32

  11. Gianluigi Martino voted on patch set 2 V 0 12/01/16, 10:40

  12. Anja Leichsenring voted on patch set 2 CR +2 V +2 12/01/16, 10:43

  13. Gerrit merged patch set 2 12/01/16, 10:43