Review TYPO3_7-6 Merged

50783[TASK] Remove has-call to caching framework in explodeSoftRefParserList

Claus Due CR +2 V +2 Easy +8 −8 updated 12/01/16, 19:04

Commit message

No need to call has on the caching framework in the function
explodeSoftRefParserList. Furthermore we do not need to store false
to the runtime cache if parseList is an empty string.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Anja Leichsenring +1
  • Verified V +2
    • Andreas Kienast +2
    • Anja Leichsenring +1

Issues 1

Files 1

Review log 79

  1. Claus Due uploaded patch set 1 11/26/16, 13:36

  2. TYPO3com voted on patch set 1 V +1 11/26/16, 13:40 Completed build in 03m 37s on Sat, 26 Nov, 02:40 PM Test Summary: 38266 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-443

  3. Anja Leichsenring voted on patch set 1 CR +1 V +1 12/01/16, 18:55

  4. Andreas Kienast voted on patch set 1 CR +2 V +2 12/01/16, 18:55

  5. Anja Leichsenring updated the commit message in patch set 2 12/01/16, 18:56

  6. Anja Leichsenring voted on patch set 2 CR +1 V +1 12/01/16, 18:57

  7. Andreas Kienast voted on patch set 2 CR +2 V +2 12/01/16, 18:57

  8. Gerrit merged patch set 2 12/01/16, 18:57

  9. TYPO3com commented on patch set 2 12/01/16, 19:04 Completed build in 07m 38s on Thu, 1 Dec, 08:04 PM Test Summary: 38274 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-465