Review main Merged

50784[BUGFIX] Avoid building SQL deleteClause expression if unused

Claus Due CR +2 V +2 Easy +7 −9 updated 11/26/16, 19:30

Commit message

This patch avoids building an instance of ConnectionPool,
getting a QueryBuilder and building an expression unless
that expression is needed by the function.

Also switches a condition with else clause to an early
return guard clause (cosmetic only).

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Stephan Großberndt +1
    • Morton Jonuschat +1
  • Verified V +2
    • Wouter Wolters +2
    • Morton Jonuschat +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Claus Due uploaded patch set 1 11/26/16, 13:43

  2. TYPO3com voted on patch set 1 V +1 11/26/16, 13:46 Completed build in 03m 35s on Sat, 26 Nov, 02:46 PM Test Summary: 55589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5142

  3. Stephan Großberndt voted on patch set 1 CR +1 11/26/16, 14:13

  4. Morton Jonuschat voted on patch set 1 CR +1 V +1 11/26/16, 18:33

  5. Wouter Wolters voted on patch set 1 CR +1 11/26/16, 19:04

  6. Wouter Wolters voted on patch set 1 CR +2 V +2 11/26/16, 19:30

  7. Gerrit merged patch set 1 11/26/16, 19:30