Review main Merged

50798[TASK] sysext/recordlist: Moved text constants to language file

Michael Oehlhof CR +2 V +2 Easy +12 −3 updated 12/01/16, 11:04

Commit message

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Daniel Alder +1
    • Jan Helke +1
    • Gianluigi Martino +1
  • Verified V +2
    • Anja Leichsenring +2
    • Daniel Alder +1
    • Jan Helke +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1113

  1. Michael Oehlhof uploaded patch set 1 11/28/16, 19:00

  2. TYPO3com voted on patch set 1 V +1 11/28/16, 19:04 Completed build in 04m 12s on Mon, 28 Nov, 08:04 PM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5180

  3. Georg Ringer commented on patch set 1 11/29/16, 04:05

    locallang_browse_links.xlf:109

    please use a better name then, otherwise it doesn't make really sense ... nobody knows what TBE is ;)
  4. Daniel Alder voted on patch set 1 V +1 12/01/16, 10:33

  5. Daniel Alder voted on patch set 1 CR +1 12/01/16, 10:33

  6. Jan Helke commented on patch set 2 12/01/16, 10:56

    Published edit on patch set 1.
  7. Jan Helke voted on patch set 2 CR +1 V +1 12/01/16, 10:57

  8. Jan Helke commented on patch set 2 12/01/16, 10:58

    TBE = TYPO3 Backend. So it could simply be removed.
  9. Gianluigi Martino voted on patch set 2 CR +1 12/01/16, 10:58

  10. TYPO3com voted on patch set 2 V +1 12/01/16, 11:01 Completed build in 04m 13s on Thu, 1 Dec, 12:01 PM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5227

  11. Daniel Alder voted on patch set 2 CR +1 V +1 12/01/16, 11:04

  12. Anja Leichsenring voted on patch set 2 CR +2 V +2 12/01/16, 11:04

  13. Gerrit merged patch set 2 12/01/16, 11:04