50809[TASK] EXT:form - let renderViewHelper work within a FLUIDTEMPLATE CE
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 79
-
Ralf Zimmermann uploaded patch set 1 11/29/16, 21:58
-
TYPO3com voted on patch set 1 V +1 11/29/16, 22:02 Completed build in 03m 52s on Tue, 29 Nov, 11:02 PM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5201
-
Wouter Wolters updated the commit message in patch set 2 11/29/16, 22:06
-
TYPO3com voted on patch set 2 V +1 11/29/16, 22:12 Completed build in 05m 21s on Tue, 29 Nov, 11:12 PM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5202
-
Claus Due commented on patch set 2 CR -1 11/30/16, 10:48
This really should be solved by creating a such a Request from within the FLUIDTEMPLATE content object. The RenderViewHelper should imho never do this. Side issue: this ViewHelper is very poorly named. It says nothing about what's being rendered, and it looks on the surface like a custom `f:render`. But that is of course not your fault and not related to this patch ;) -
Ralf Zimmermann commented on patch set 2 11/30/16, 11:32
"This really should be solved by creating a such a Request from within the FLUIDTEMPLATE content object." I agree. The FLUIDTEMPLATE should initialize the Request. At the moments the FLUIDTEMPLATE initialize a Fluid StandaloneView which initialize an empty TYPO3\CMS\Extbase\Mvc\Web\Request and no arguments will be initialized. "this ViewHelper is very poorly named. It says nothing about what's being rendered, and it looks on the surface like a custom `f:render`" The main entry point to render ext:form form is the render viewhelper, not the extbase controller. The idea is, to put this viewhelper somewere in a fluid template and hand over a factory class and/or a additional configuration and/or a persistence identifier which should be rendered. After that, the ext:form framework will be initialized by the request and render the form depending on the configured renderer. The renderer could be some other thing like a fluid template view. I think this is more than a additional/custom "f:render" view helper. Because it's the main entry point i think the name is not so false because it render a ext:form form. But I am open to suggestions. How does it go on here. Should I open a new ticket for the FLUIDTEMPLATE thing and explain the usecase and link to this patchset? -
Claus Due commented on patch set 2 11/30/16, 11:48
> At the moments the FLUIDTEMPLATE initialize a Fluid StandaloneView which initialize an empty TYPO3\CMS\Extbase\Mvc\Web\Request and no arguments will be initialized. This is sort of a problem in its own regard. FLUIDTEMPLATE should mimic an actual request, and ideally it would support a dynamic/unique controller, action, vendor or extension scope. Which would, coincidentally, also solve the issues surrounding collisions of cached templates when using FLUIDTEMPLATE. > The renderer could be some other thing like a fluid template view. I think this is more than a additional/custom "f:render" view helper. Because it's the main entry point i think the name is not so false because it render a ext:form form. > But I am open to suggestions. `form:form` so it matches `f:form` in logical context. > How does it go on here. Should I open a new ticket for the FLUIDTEMPLATE thing and explain the usecase and link to this patchset? Sounds good :) -
Ralf Zimmermann commented on patch set 2 CR -1 V -1 11/30/16, 12:13
-
Ralf Zimmermann abandoned the change 12/01/16, 14:44
https://forge.typo3.org/issues/78842 solve this issue.