Review main Merged

50812[BUGFIX] HTML5: use self-closing tags only if allowed

Markus Mächler CR +2 V +2 Normal +117 −2 updated 02/11/18, 12:17

Commit message

For HTML5 only certain HTML tags are allowed to be self-closing
(e.g. <img src="..." />), so this needs to be checked when
parsing HTML.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Mathias Schreiber +1
  • Verified V +2
    • Jigal van Hemert +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1623

  1. Markus Mächler uploaded patch set 1 11/30/16, 14:58

  2. Markus Mächler updated the commit message in patch set 2 11/30/16, 15:00

  3. Markus Mächler updated the commit message in patch set 3 11/30/16, 15:00

  4. TYPO3com voted on patch set 1 V -1 11/30/16, 15:03 Completed build in 04m 45s on Wed, 30 Nov, 04:03 PM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5206

  5. TYPO3com voted on patch set 2 V -1 11/30/16, 15:05 Completed build in 05m 07s on Wed, 30 Nov, 04:05 PM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5207

  6. TYPO3com voted on patch set 3 V -1 11/30/16, 15:07 Completed build in 06m 35s on Wed, 30 Nov, 04:07 PM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5208

  7. Oliver Klee commented on patch set 3 12/01/16, 10:39

    ContentObjectRenderer.php:4968

    Please let's have a strict in_array.
  8. Oliver Klee commented on patch set 3 12/01/16, 10:40

    Can we have unit tests for this change?

    ContentObjectRenderer.php:4965

    This can be an @see annotation.
  9. Benni Mack commented on patch set 3 12/01/16, 10:54

    Unit Tests would be really nice for that.
  10. Oliver Klee commented on patch set 3 CR -1 12/01/16, 11:22

    ContentObjectRenderer.php:4968 Reply

    The array should use the short array notation: []
  11. Markus Mächler uploaded patch set 4 12/07/16, 07:16

  12. TYPO3com voted on patch set 4 V -1 12/07/16, 07:22 Completed build in 05m 51s on Wed, 7 Dec, 08:22 AM Test Summary: 54379 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5540

  13. Benni Mack updated the commit message in patch set 5 05/12/17, 04:52

  14. TYPO3com voted on patch set 5 V -1 05/12/17, 04:57 Completed build in 05m 16s on Fri, 12 May, 06:57 AM Test Summary: 55856 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11450

  15. Benni Mack uploaded patch set 6 05/12/17, 05:00

  16. TYPO3com voted on patch set 6 V +1 05/12/17, 05:05 Completed build in 05m 19s on Fri, 12 May, 07:05 AM Test Summary: 55856 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11451

  17. Elmar Hinz commented on patch set 6 05/12/17, 06:45

    ContentObjectRenderer.php:4446

    if($emptyTag && ($keepTag || $keepEmptyTag)) { ... } else if ($keepTag) { ... }

    ContentObjectRenderer.php:4451

    cryptic

    ContentObjectRendererTest.php:4935

    This is not shown.

    ContentObjectRendererTest.php:4938

    Hence there are no parameters or a return value.

    ContentObjectRendererTest.php:4942

    Could you rephrase the test methods to that they can follow the sentence "Test, that it ..."? (Mathias Brodala) See discussion upon method names within this class: https://review.typo3.org/#/c/52378/

    ContentObjectRendererTest.php:4978

    not allowed
  18. Mathias Schreiber uploaded patch set 7 02/06/18, 18:21

  19. TYPO3com voted on patch set 7 V +1 02/06/18, 18:29 Completed build in 08m 11s on Tue, 6 Feb, 07:29 PM Test Summary: 30497 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19024

  20. Mathias Schreiber voted on patch set 7 V +1 CR +1 02/11/18, 00:23

  21. Jigal van Hemert voted on patch set 7 V +2 CR +2 02/11/18, 12:16

  22. Jigal van Hemert merged patch set 8 02/11/18, 12:16

  23. Jigal van Hemert commented on patch set 8 02/11/18, 12:17

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 3349e50b3dfbe6323ebe968969c910c822cee7bc