Review main Merged

50863[TASK] Remove compatiblity code added for security release

Helmut Hummel CR +2 V +2 Normal +9 −60 updated 12/03/16, 16:21

Commit message

Remove the overhead that was added to avoid BC breaks for
extension code that subclassed the form view helper.

Enough time is now passed so that extensions can adopt their
subclasses so that the security related hidden field is added as well.

These adaptions will then be compatible with all TYPO3 versions
so that this change here is not marked as breaking.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Susi Moog +1
  • Verified V +2
    • Anja Leichsenring +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Helmut Hummel uploaded patch set 1 12/02/16, 22:55

  2. TYPO3com voted on patch set 1 V +1 12/02/16, 22:59 Completed build in 04m 00s on Fri, 2 Dec, 11:59 PM Test Summary: 54202 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5372

  3. Anja Leichsenring updated the commit message in patch set 2 12/03/16, 08:51

  4. TYPO3com voted on patch set 2 V +1 12/03/16, 08:56 Completed build in 05m 33s on Sat, 3 Dec, 09:56 AM Test Summary: 54202 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5374

  5. Anja Leichsenring commented on patch set 2 12/03/16, 08:57

    the change introducing the code that is removed here (https://review.typo3.org/#/c/49104) was only merged yesterday. Should it really be removed again now?
  6. Helmut Hummel commented on patch set 2 12/03/16, 15:26

    Thanks for creating the forge ticket. I was too tired and thus too lazy yesterday, but wanted to push something, so that it won't get lost. > the change introducing the code that is removed here (https://review.typo3.org/#/c/49104) was only merged yesterday that is not entirely true. That code was introduced as part of a security fix in May: https://review.typo3.org/#/c/48258/ Because of the high impact of the security issue, the code has been tried to be made defensive enough to not introduce a BC. This complexity was never intended to stay for master. Besides that, it was buggy and this bug was now consistently fixed across branches (I'm pretty confident here now), which is good, but the complexity should still be removed for master eventually (or better now than later).
  7. Susi Moog voted on patch set 2 CR +1 12/03/16, 15:27

  8. Susi Moog voted on patch set 2 V +1 12/03/16, 15:36

  9. Anja Leichsenring commented on patch set 2 CR +2 V +2 12/03/16, 16:21

    Thanks for clarification. That was not entirely transparent to me.
  10. Gerrit merged patch set 2 12/03/16, 16:21