Review main Merged

50881[BUGFIX] Fix injured workspace encapsulation in record localize summary.

Gleb Levitin CR +2 V +2 Normal +116 −3 updated 11/30/17, 15:49

Commit message

This patch resolves problem with the injured workspace encapsulation
for removed records while fetching the record localize summary in page
module within a workspace.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 2742

Show 1017 earlier messages
  1. Gleb Levitin uploaded patch set 1 12/04/16, 12:05

  2. Gleb Levitin uploaded patch set 2 12/04/16, 12:07

  3. Gleb Levitin uploaded patch set 3 12/04/16, 12:09

  4. TYPO3com voted on patch set 1 V -1 12/04/16, 12:10 Completed build in 04m 32s on Sun, 4 Dec, 01:10 PM Test Summary: 54316 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5502

  5. TYPO3com voted on patch set 2 V -1 12/04/16, 12:12 Completed build in 05m 23s on Sun, 4 Dec, 01:12 PM Test Summary: 54326 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5503

  6. TYPO3com voted on patch set 3 V -1 12/04/16, 12:14 Completed build in 05m 08s on Sun, 4 Dec, 01:14 PM Test Summary: 54326 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5504

  7. Gleb Levitin uploaded patch set 4 12/04/16, 12:15

  8. TYPO3com voted on patch set 4 V +1 12/04/16, 12:19 Completed build in 04m 39s on Sun, 4 Dec, 01:19 PM Test Summary: 54326 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5505

  9. Anja Leichsenring updated the commit message in patch set 5 12/04/16, 12:55

  10. TYPO3com voted on patch set 5 V +1 12/04/16, 13:00 Completed build in 05m 21s on Sun, 4 Dec, 02:00 PM Test Summary: 54326 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5507

  11. Oliver Hader commented on patch set 5 V +1 12/04/16, 13:18

    Looks good in general. However, the missing workspaces overlays might be a topic for other records/uids fetched from the LocalizationRepository as well
  12. Gleb Levitin commented on patch set 5 12/04/16, 14:49

    This patch just fixes the workspace bug, described in https://forge.typo3.org/issues/78841. The functional test coverage refers also to the made improvement.
  13. Gleb Levitin uploaded patch set 6 12/07/16, 12:25

  14. TYPO3com voted on patch set 6 V +1 12/07/16, 12:30 Completed build in 05m 13s on Wed, 7 Dec, 01:30 PM Test Summary: 54377 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5567

  15. Mona Muzaffar uploaded patch set 7 06/17/17, 00:03

  16. TYPO3com voted on patch set 7 V -1 06/17/17, 00:13 Completed build in 10m 27s on Sat, 17 Jun, 02:13 AM Test Summary: 3 of 56523 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12645

  17. Gleb Levitin uploaded patch set 8 06/23/17, 12:51

  1. TYPO3com voted on patch set 8 V -1 06/23/17, 12:52 Completed build in 10s on Fri, 23 Jun, 02:52 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12811

  2. Gleb Levitin uploaded patch set 9 06/23/17, 13:19

  3. Gleb Levitin commented on patch set 9 06/23/17, 13:22

    > Uploaded patch set 8. * Replace deprecated ActionService class with the original one from the testing framework * Improve some logik in the test
  4. Gleb Levitin commented on patch set 9 06/23/17, 13:23

    > > Uploaded patch set 8. > > make source code cgl compatible
  5. TYPO3com voted on patch set 9 V -1 06/23/17, 13:30 Completed build in 10m 49s on Fri, 23 Jun, 03:30 PM Test Summary: 1 of 56729 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12812

  6. TYPO3com voted on patch set 9 V +1 06/24/17, 16:27 Completed build in 3h 18m 05s on Sat, 24 Jun, 06:27 PM Test Summary: 56726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12812

  7. Andreas Kienast commented on patch set 9 06/24/17, 16:49

    LocalizationController.php:144

    How can this be the case? Isn't that caught by the while clause already?
  8. Andreas Kienast commented on patch set 9 06/24/17, 16:51

    LocalizationController.php:144 Reply

    Never mind, BackendUtility::workspaceOL() gets $row as reference and might set it to false.
  9. Andreas Kienast uploaded patch set 10 06/24/17, 16:57

  10. Andreas Kienast commented on patch set 10 06/24/17, 16:58

    I changed the code slightly, as in case $row is false, the previously accessed $row['t3ver_state'] triggers a notice.
  11. TYPO3com voted on patch set 10 V -1 06/24/17, 17:07 Completed build in 09m 29s on Sat, 24 Jun, 07:07 PM Test Summary: 2 of 56730 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12824

  12. TYPO3com commented on patch set 10 06/24/17, 17:14 Completed build in 26m 26s on Sat, 24 Jun, 07:14 PM Test Summary: 2 of 56730 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12824

  13. Andreas Kienast uploaded patch set 11 06/24/17, 17:40

  14. TYPO3com voted on patch set 11 V +1 06/24/17, 17:50 Completed build in 10m 04s on Sat, 24 Jun, 07:50 PM Test Summary: 56727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12825

  15. Rolf Hofmann voted on patch set 11 CR +1 06/30/17, 15:17

  16. Oliver Hader voted on patch set 11 CR +1 11/29/17, 17:26

  17. Oliver Hader voted on patch set 11 V +1 11/29/17, 17:26

  18. Oliver Hader updated the commit message in patch set 12 11/29/17, 17:55

  19. TYPO3com voted on patch set 12 V -1 11/29/17, 18:08 Completed build in 12m 59s on Wed, 29 Nov, 07:08 PM Test Summary: 14 of 57365 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17012

  20. Oliver Hader uploaded patch set 13 11/29/17, 19:07

  21. TYPO3com voted on patch set 13 V +1 11/29/17, 19:18 Completed build in 10m 48s on Wed, 29 Nov, 08:18 PM Test Summary: 57000 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17026

  22. Oliver Hader voted on patch set 13 CR +1 V +1 11/30/17, 15:49

  23. Oliver Hader voted on patch set 13 CR +2 V +2 11/30/17, 15:49

  24. Gerrit merged patch set 13 11/30/17, 15:49

  25. Oliver Hader commented on patch set 14 11/30/17, 15:49

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit c79f8afc2b0b5f95b25a4d5a4dfe3ea5d20c7316