Review main Merged

50890[BUGFIX] Fix IP lock clause when [FE][lockIP] is 0

Wouter Wolters CR +2 V +2 Easy +6 −2 updated 12/08/16, 20:15

Commit message

The method getNewSessionRecord doesn't check
lockIP setting 0 correctly. Add a check to disable checking
when lockIP is 0.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1521

  1. Wouter Wolters uploaded patch set 1 12/07/16, 09:13

  2. TYPO3com voted on patch set 1 V +1 12/07/16, 09:17 Completed build in 03m 53s on Wed, 7 Dec, 10:17 AM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5544

  3. Mathias Brodala commented on patch set 1 12/07/16, 09:27

    AbstractUserAuthentication.php:1194

    I guess this should be updated to document the behavior for "0".
  4. Wouter Wolters uploaded patch set 2 12/07/16, 09:39

  5. TYPO3com voted on patch set 2 V +1 12/07/16, 09:43 Completed build in 04m 09s on Wed, 7 Dec, 10:43 AM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5546

  6. Wouter Wolters uploaded patch set 3 12/07/16, 10:05

  7. Wouter Wolters uploaded patch set 4 12/07/16, 10:06

  8. TYPO3com voted on patch set 3 V -1 12/07/16, 10:09 Completed build in 03m 10s on Wed, 7 Dec, 11:08 AM Test Summary: 1428 of 54381 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5548

  9. Mathias Brodala voted on patch set 4 CR +1 12/07/16, 10:09

  10. TYPO3com voted on patch set 4 V -1 12/07/16, 10:10 Completed build in 03m 26s on Wed, 7 Dec, 11:10 AM Test Summary: 1428 of 54381 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5549

  11. Wouter Wolters uploaded patch set 5 12/07/16, 10:27

  12. TYPO3com voted on patch set 5 V -1 12/07/16, 10:31 Completed build in 03m 30s on Wed, 7 Dec, 11:31 AM Test Summary: 1428 of 54381 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5553

  13. Wouter Wolters uploaded patch set 6 12/07/16, 10:37

  14. TYPO3com voted on patch set 6 V +1 12/07/16, 10:42 Completed build in 04m 25s on Wed, 7 Dec, 11:42 AM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5554

  15. Susi Moog voted on patch set 6 CR +1 12/07/16, 12:20

  16. Susi Moog voted on patch set 6 V +1 12/07/16, 12:25

  17. Christian Kuhn voted on patch set 6 CR +1 12/08/16, 19:46

  18. Anja Leichsenring voted on patch set 6 CR +1 V +1 12/08/16, 19:47

  19. Christian Kuhn voted on patch set 6 CR +2 V +2 12/08/16, 20:15

  20. Gerrit merged patch set 6 12/08/16, 20:15

  21. Christian Kuhn commented on patch set 7 12/08/16, 20:15

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 294109416b41f2956437b8ea21a9ca8b43241421