Review main Merged

50895[TASK] Show warning when deleting an element which has references

Michael Stucki CR +2 V +2 Normal +68 −13 updated 02/08/18, 13:35

Commit message

Show the same warning in the page module as done in the list module,
except without the title and the table:uid combination, as this is
not needed in page module. It will always be tt_content records there.

Review

  • Code review CR +2
    • Susi Moog +2
    • Steffen Frese +1
    • Mathias Schreiber +1
    • Jörg Bösche +1
  • Verified V +2
    • Susi Moog +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 2229

Show 34 earlier messages
  1. Michael Stucki uploaded patch set 1 12/07/16, 17:26

  2. TYPO3com voted on patch set 1 V +1 12/07/16, 17:31 Completed build in 04m 24s on Wed, 7 Dec, 06:31 PM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5584

  3. Gleb Levitin commented on patch set 1 CR -1 V -1 12/07/16, 17:41

    PageLayoutView.php:2534

    The method `getDatabase()` is not implemented.

    PageLayoutView.php:2536

    The database abstraction layer of TYPO3 is deprecated. Doctrine DBAL is to be used instead.
  4. Oliver Klee commented on patch set 1 12/08/16, 09:33

    Isn't this more of a FEATURE?
  1. Gleb Levitin commented on patch set 1 CR 0 V 0 12/08/16, 09:35

    rst file also missing
  2. Gleb Levitin voted on patch set 1 CR -1 V -1 12/08/16, 09:35

  3. Benni Mack commented on patch set 1 11/29/17, 00:19

    please rebase.
  4. Anja Leichsenring uploaded patch set 2 02/07/18, 20:20

  5. TYPO3com voted on patch set 2 V +1 02/07/18, 20:29 Completed build in 08m 35s on Wed, 7 Feb, 09:29 PM Test Summary: 30461 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19096

  6. Mathias Schreiber voted on patch set 2 V +1 CR +1 02/07/18, 20:31

  7. Riccardo De Contardi voted on patch set 2 V +1 02/07/18, 20:36

  8. Mathias Schreiber uploaded patch set 3 02/07/18, 21:59

  9. TYPO3com voted on patch set 3 V -1 02/07/18, 21:59 Completed build in 13s on Wed, 7 Feb, 10:59 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19117

  10. Mathias Schreiber uploaded patch set 4 02/07/18, 22:00

  11. Mathias Schreiber uploaded patch set 5 02/07/18, 22:05

  12. TYPO3com voted on patch set 4 V +1 02/07/18, 22:07 Completed build in 07m 39s on Wed, 7 Feb, 11:07 PM Test Summary: 30461 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19118

  13. TYPO3com voted on patch set 5 V +1 02/07/18, 22:11 Completed build in 06m 23s on Wed, 7 Feb, 11:11 PM Test Summary: 30461 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19120

  14. Riccardo De Contardi commented on patch set 5 V -1 02/07/18, 22:32

    ether it is just me, or the warning is now absent on both page and list view.
  15. Susi Moog uploaded patch set 6 02/08/18, 07:32

  16. TYPO3com voted on patch set 6 V +1 02/08/18, 07:41 Completed build in 08m 57s on Thu, 8 Feb, 08:41 AM Test Summary: 30461 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19123

  17. Mathias Schreiber commented on patch set 6 V +1 CR +1 02/08/18, 08:43

    I guess that code is more in line with the other selects
  18. Tobi Kretschmann uploaded patch set 7 02/08/18, 09:30

  19. TYPO3com voted on patch set 7 V +1 02/08/18, 09:39 Completed build in 08m 15s on Thu, 8 Feb, 10:39 AM Test Summary: 30461 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19128

  20. Jörg Bösche voted on patch set 7 CR +1 02/08/18, 09:39

  21. Steffen Frese voted on patch set 7 CR +1 02/08/18, 09:43

  22. Mathias Schreiber voted on patch set 7 V +1 CR +1 02/08/18, 10:32

  23. Susi Moog voted on patch set 7 V +2 CR +2 02/08/18, 13:13

  24. Susi Moog merged patch set 8 02/08/18, 13:14

  25. Michael Stucki commented on patch set 8 02/08/18, 13:35

    Thank you all for finishing this change!