Review main Merged

50900[BUGFIX] Order extensions by integerVersion instead of version

TYPO3com CR +2 V +2 Easy +1 −1 updated 12/12/16, 16:12

Commit message

Return the results of findByExtensionKeyOrderedByVersion ordered by 
column 'integerVersion' instead of 'version' in order to avoid a wrong 
order for version numbers like "1.9.2" and "1.10.0".

Review

  • Code review CR +2
    • Markus Klein +2
    • Georg Ringer +1
    • Tymoteusz Motylewski +1
  • Verified V +2
    • Markus Klein +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1419

  1. TYPO3com uploaded patch set 1 12/08/16, 14:53

  2. TYPO3com voted on patch set 1 V +1 12/08/16, 14:57 Completed build in 04m 09s on Thu, 8 Dec, 03:57 PM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5599

  3. Mathias Brodala updated the commit message in patch set 2 12/08/16, 15:21

  4. TYPO3com voted on patch set 2 V +1 12/08/16, 15:26 Completed build in 04m 29s on Thu, 8 Dec, 04:26 PM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5601

  5. Stephan Großberndt updated the commit message in patch set 3 12/08/16, 17:04

  6. Stephan Großberndt voted on patch set 3 CR +1 12/08/16, 17:04

  7. Stephan Großberndt commented on patch set 3 12/08/16, 17:08

    One might argue there should be another method findByExtensionKeyOrderedByIntegerVersion instead and this one left as it is but since findByExtensionKeyOrderedByVersion returns the extensions in a wrong order I think this is the right choice.
  8. TYPO3com voted on patch set 3 V +1 12/08/16, 17:08 Completed build in 03m 44s on Thu, 8 Dec, 06:08 PM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5606

  9. Oliver Klee commented on patch set 3 12/08/16, 17:25

    Why is "TYPOcom" the owner of this change request (instead of some natural person)?
  10. Wouter Wolters commented on patch set 3 12/08/16, 17:50

    @oliver This changes comes from Github as a PR. The service pushed this change automatically and closed the PR on Github.
  11. Anja Leichsenring commented on patch set 3 12/08/16, 18:11

    not for 6.2. This bug is not critical.
  12. Anja Leichsenring updated the commit message in patch set 4 12/08/16, 18:13

  13. TYPO3com voted on patch set 4 V +1 12/08/16, 18:18 Completed build in 04m 13s on Thu, 8 Dec, 07:18 PM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5608

  14. Tymoteusz Motylewski voted on patch set 4 CR +1 12/12/16, 11:08

  15. Georg Ringer voted on patch set 4 CR +1 V +1 12/12/16, 12:04

  16. Markus Klein voted on patch set 4 CR +1 V +1 12/12/16, 16:12

  17. Markus Klein voted on patch set 4 CR +2 V +2 12/12/16, 16:12

  18. Gerrit merged patch set 4 12/12/16, 16:12

  19. Markus Klein commented on patch set 5 12/12/16, 16:12

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit e996b61d47cc778f6b184aa9d327f1d23388b804