50904[TASK] Lowlevel: Clean up $versionSwapmode
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Wouter Wolters +1
-
Verified V +2
- Susi Moog +2
- Wouter Wolters +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 79
-
Benni Mack uploaded patch set 1 12/08/16, 17:00
-
TYPO3com voted on patch set 1 V -1 12/08/16, 17:05 Completed build in 05m 39s on Thu, 8 Dec, 06:05 PM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5604
-
Wouter Wolters uploaded patch set 2 12/09/16, 20:09
-
Wouter Wolters voted on patch set 2 CR +1 V +1 12/09/16, 20:10
-
TYPO3com voted on patch set 2 V +1 12/09/16, 20:13 Completed build in 04m 35s on Fri, 9 Dec, 09:13 PM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5667
-
Susi Moog commented on patch set 2 CR -1 12/10/16, 11:52
Please take a look at my comment. While I'm in general fine with keeping the var as function param for BC I think we should remove the condition.CleanerCommand.php:479$versionSwapmode can never be true here (as far as I can see it's not set anywhere anymore) - or am I missing something? -
Wouter Wolters commented on patch set 2 12/10/16, 12:24
CleanerCommand.php:479Replyit is set on line 604 -
Susi Moog commented on patch set 2 CR +2 V +2 12/11/16, 18:44
CleanerCommand.php:479Replyah damn, that's why phpstorm didn't pick it up, because it's not used as the var.. thanks for the pointer. -
Gerrit merged patch set 2 12/11/16, 18:44