Review main Merged

50924[FOLLOWUP] Add functional test for cache backend flushByTags

Claus Due CR +2 V +2 Normal +90 −70 updated 12/19/16, 06:26

Commit message

Followup to https://review.typo3.org/#/c/50537/ to add
functional tests covering the new SQL operations.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Claus Due +1
    • Nicole Hummel +1
  • Verified V +2
    • Georg Ringer +2
    • Claus Due +1
    • Nicole Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1624

  1. Claus Due uploaded patch set 1 12/11/16, 00:00

  2. Claus Due uploaded patch set 2 12/11/16, 00:04

  3. TYPO3com voted on patch set 1 V -1 12/11/16, 00:06 Completed build in 05m 02s on Sun, 11 Dec, 01:06 AM Test Summary: 4 of 54381 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5677

  4. TYPO3com voted on patch set 2 V +1 12/11/16, 00:08 Completed build in 03m 59s on Sun, 11 Dec, 01:08 AM Test Summary: 54381 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5678

  5. Nicole Hummel commented on patch set 2 CR -1 12/11/16, 18:55

    I tend to move the mocking to an own function as this would prevent code duplication of preparing the test scenario.

    Typo3DatabaseBackendTest.php:511

    Wrong comment

    Typo3DatabaseBackendTest.php:561

    Wrong comment
  6. Claus Due uploaded patch set 3 12/16/16, 11:32

  7. Claus Due uploaded patch set 4 12/16/16, 11:33

  8. TYPO3com voted on patch set 3 V -1 12/16/16, 11:37 Completed build in 04m 31s on Fri, 16 Dec, 12:37 PM Test Summary: 20 of 54399 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5811

  9. Claus Due uploaded patch set 5 12/16/16, 11:37

  10. TYPO3com voted on patch set 4 V -1 12/16/16, 11:38 Completed build in 05m 47s on Fri, 16 Dec, 12:38 PM Test Summary: 2 of 54399 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5812

  11. Claus Due uploaded patch set 6 12/16/16, 11:41

  12. TYPO3com voted on patch set 5 V -1 12/16/16, 11:41 Completed build in 03m 55s on Fri, 16 Dec, 12:41 PM Test Summary: 2 of 54399 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5813

  13. Claus Due uploaded patch set 7 12/16/16, 11:45

  14. TYPO3com voted on patch set 6 V -1 12/16/16, 11:45 Completed build in 04m 12s on Fri, 16 Dec, 12:45 PM Test Summary: 2 of 54399 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5814

  15. TYPO3com voted on patch set 7 V +1 12/16/16, 11:50 Completed build in 04m 49s on Fri, 16 Dec, 12:50 PM Test Summary: 54399 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5815

  16. Nicole Hummel commented on patch set 7 CR -1 12/16/16, 12:01

    Working on it
  17. Nicole Hummel uploaded patch set 8 12/16/16, 12:32

  18. Nicole Hummel voted on patch set 8 CR +1 V +1 12/16/16, 12:32

  19. TYPO3com voted on patch set 8 V +1 12/16/16, 12:36 Completed build in 04m 13s on Fri, 16 Dec, 01:36 PM Test Summary: 54399 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5820

  20. Claus Due commented on patch set 8 12/16/16, 17:04

    Looks fine to me - as far as this merge request goes, I'd call it ready!
  21. Nicole Hummel commented on patch set 8 12/16/16, 20:06

    @Claus: As I changed the patch, you may vote as well.
  22. Claus Due voted on patch set 8 CR +1 V +1 12/16/16, 23:24

  23. Georg Ringer voted on patch set 8 CR +2 V +2 12/19/16, 06:26

  24. Gerrit merged patch set 8 12/19/16, 06:26