Review TYPO3_6-2 Merged

50930[BUGFIX] Reflection Cache does not save methodReflections

Tymoteusz Motylewski CR +2 V +2 Easy +1 −0 updated 12/12/16, 13:45

Commit message

The cached data of the Reflection Cache (table cf_extbase_reflection)
is not stored in its complete form.

The data/part of property 'methodReflections' is NOT stored in the cache.
As a result, the Reflection Cache will be deleted/inserted each time the
methodReflections property is needed

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Valentin Despa +1
    • Wouter Wolters +1
    • Anja Leichsenring +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Valentin Despa +1
    • Wouter Wolters +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Tymoteusz Motylewski uploaded patch set 1 12/12/16, 10:37

  2. Tymoteusz Motylewski commented on patch set 1 12/12/16, 10:40

    As this is a patch to the "priority bugfixes only" branch. I'm asking for the review and final decision whether it can go to the 6.2.
  3. TYPO3com voted on patch set 1 V +1 12/12/16, 10:41 Completed build in 04m 00s on Mon, 12 Dec, 11:41 AM Test Summary: 30884 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC6-75

  4. Anja Leichsenring commented on patch set 1 CR +1 V +1 12/12/16, 11:04

    I opt for integrating it. The performance gain should justify for the change, and I can't find any side effects.
  5. Valentin Despa commented on patch set 1 CR +1 V +1 12/12/16, 12:58

    It would make a lot of sense to integrate it in 6.2.
  6. Wouter Wolters commented on patch set 1 CR +1 V +1 12/12/16, 13:40

    I agree here on merging this in 6.2.
  7. Tymoteusz Motylewski commented on patch set 1 CR +2 V +2 12/12/16, 13:45

    let's get it in then :)
  8. Gerrit merged patch set 1 12/12/16, 13:45