50934[BUGFIX] TCA: Make ###CURRENT_PID### work in foreign_table_where in IRRE
Commit message
Review
-
Code review CR +2
- Nicole Hummel +2
- Markus Klein +1
-
Verified V +2
- Nicole Hummel +2
- Jasmina Ließmann +1
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 2630
Show 45 earlier messages
-
Nicole Hummel uploaded patch set 1 12/12/16, 16:53
-
TYPO3com voted on patch set 1 V +1 12/12/16, 16:57 Completed build in 04m 26s on Mon, 12 Dec, 05:57 PM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5704
-
Andreas Kienast commented on patch set 1 CR -1 12/12/16, 17:21
Releases line is missing -
Mathias Schreiber updated the commit message in patch set 2 12/12/16, 17:23
-
Mathias Schreiber commented on patch set 2 12/12/16, 17:24
From the ticket I read that this affects the new FormEngine on V7, so I took the liberty to add the releases line accordingly. @Nicole: If my assumptions are wrong, just correct the message again.
-
TYPO3com voted on patch set 2 V +1 12/12/16, 17:28 Completed build in 04m 29s on Mon, 12 Dec, 06:28 PM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5705
-
Nicole Hummel commented on patch set 2 12/12/16, 21:11
Thanks for fixing this. master and 7.6 are correct -
Philipp Gampe voted on patch set 2 CR +1 12/31/16, 13:44
-
Markus Klein commented on patch set 2 01/03/17, 10:42
TcaInline.php:255just because of curiosity: we deal with inline here (no flexforms involved) and still we need to set a flexform attribute here? -
Nicole Hummel commented on patch set 2 01/03/17, 12:57
TcaInline.php:255ReplyYes, this is the property taken into account on resolving markers like ###CURRENT_PID### in foreign_table_where clause. -
Jasmina Ließmann voted on patch set 2 CR +1 02/13/17, 13:07
-
Christian Matthes voted on patch set 2 CR +1 02/13/17, 13:11
-
Christian Matthes voted on patch set 2 V +1 02/13/17, 13:13
-
Jasmina Ließmann voted on patch set 2 V +1 02/13/17, 13:14
-
Markus Klein commented on patch set 2 CR -2 02/13/17, 15:48
I think the fix is wrong. The problem is rather in typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php:1056 which does not cope for the case where we have no flexforms. Lets add a check like in typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php:1038 -
Markus Klein commented on patch set 2 02/13/17, 16:07
I'm taking a look -
Markus Klein uploaded patch set 3 02/19/17, 23:03
-
Markus Klein voted on patch set 2 CR 0 02/19/17, 23:03
-
Markus Klein voted on patch set 3 CR 0 02/19/17, 23:03
-
Markus Klein commented on patch set 3 CR +1 V +1 02/19/17, 23:03
works for me now -
TYPO3com voted on patch set 3 V +1 02/19/17, 23:10 Completed build in 06m 45s on Mon, 20 Feb, 12:10 AM Test Summary: 56364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8283
-
Nicole Hummel commented on patch set 3 CR -1 02/20/17, 15:21
The commit message needs adjustments as the mentioned fix is not valid anymore -
Markus Klein updated the commit message in patch set 4 02/21/17, 00:00
-
Markus Klein voted on patch set 4 CR +1 V +1 02/21/17, 00:00
-
TYPO3com voted on patch set 4 V +1 02/21/17, 00:08 Completed build in 07m 26s on Tue, 21 Feb, 01:08 AM Test Summary: 56381 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8323
-
Nicole Hummel voted on patch set 4 CR +1 V +1 02/25/17, 09:47
-
Jasmina Ließmann voted on patch set 4 V +1 02/26/17, 19:26
-
Nicole Hummel voted on patch set 4 CR +2 V +2 02/26/17, 20:19
-
Gerrit merged patch set 4 02/26/17, 20:19
-
Nicole Hummel commented on patch set 5 02/26/17, 20:20
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit f2feeca827172438c1210fd4b935bb5346ca1f59