Review main Merged

50937[TASK] Update d3 to 4.4.0

Andreas Kienast CR +2 V +2 Easy +9 −9 updated 01/02/17, 08:25

Commit message

* Add identity.reflectX and identity.reflectY to d3.geoIdentity.
* Add zoom.interpolate to control zoom transition behavior.
* Allow double-click and double-tap zoom transitions to be disabled.
* Fix handling of a zoom.translateExtent smaller than the zoom.extent.
* Fix handling of zero-valued nodes in squarified treemaps.
* Fix parsing of unusual number formats in color specifications.
* Fix implementations of force.initialize to allow isolation.
* Fix d3.geoPath’s default projection and contex to be null, not undefined.
* Improve performance of d3.path.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
  • Verified V +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 68

  1. Andreas Kienast uploaded patch set 1 12/12/16, 18:00

  2. TYPO3com voted on patch set 1 V +1 12/12/16, 18:04 Completed build in 03m 46s on Mon, 12 Dec, 07:04 PM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5708

  3. Wouter Wolters commented on patch set 1 CR +1 V +1 12/22/16, 11:09

    selectTree still works fine.
  4. Andreas Kienast uploaded patch set 2 01/02/17, 08:16

  5. TYPO3com voted on patch set 2 V +1 01/02/17, 08:22 Completed build in 05m 40s on Mon, 2 Jan, 09:22 AM Test Summary: 54437 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6147

  6. Wouter Wolters voted on patch set 2 CR +1 V +1 01/02/17, 08:25

  7. Georg Ringer voted on patch set 2 CR +2 V +2 01/02/17, 08:25

  8. Gerrit merged patch set 2 01/02/17, 08:25