Review main Merged

50939[TASK] Update ckeditor to 4.6.1

Andreas Kienast CR +2 V +2 Expert +634 −597 updated 12/29/16, 08:25

Commit message

New Features:
* The callback parameter in the CKEDITOR.ajax.post method became optional.

Fixed Issues:
* [Blink, WebKit] Fixed: Cannot select all editor content when a widget or
a non-editable element is the first or last element of the content. Also
fixes this issue in the Select All plugin.
* [Blink, WebKit, IE8] Fixed: Browser hangs when a table is inserted in
the place of a selected list with an empty last item.
* Fixed: Improved the Color Button plugin which will now normalize the CSS
background property if it only contains a color value. This fixes missing
background colors when using Paste from Word.
+ [Blink, WebKit] Fixed: Error thrown occasionally by an uninitialized
editable for multiple CKEditor instances on the same page.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2
    • Benni Mack +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 86

Show 66 more files

Review log 45

  1. Andreas Kienast uploaded patch set 1 12/12/16, 18:14

  2. TYPO3com voted on patch set 1 V +1 12/12/16, 18:18 Completed build in 03m 38s on Mon, 12 Dec, 07:18 PM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5710

  3. Wouter Wolters commented on patch set 1 CR +1 V +1 12/22/16, 11:11

    ckeditor still loads and the editor is still experimental, IMO save to merge.
  4. Benni Mack voted on patch set 1 CR +2 V +2 12/29/16, 08:25

  5. Gerrit merged patch set 1 12/29/16, 08:25