5094[BUGFIX] check for required PHP modules in Reports module
Commit message
Review
-
Code review CR +2
- Ernesto Baschny +2
- Oliver Hader +2
- Xavier Perseguers +1
-
Verified V +2
- Ernesto Baschny +2
- Xavier Perseguers +1
Files 2
Review log 21
-
Ernesto Baschny merged patch set 1 09/20/11, 14:28
-
Xavier Perseguers commented on patch set 1 09/20/11, 14:28
(2 inline comments)class.tx_reports_reports_status_systemstatus.php:214Missing PHP Docclass.tx_reports_reports_status_systemstatus.php:219why two lines here? -
Xavier Perseguers commented on patch set 1 1 comment 09/20/11, 14:28
I would prefer that you didn't submit this -
Georg Ringer commented on patch set 1 09/20/11, 14:28
Looks good to me, but someone else must approveclass.tx_reports_reports_status_systemstatus.php:238just do an else if instead of an if inside an else -
Jigal van Hemert commented on patch set 1 09/20/11, 14:28
(3 inline comments)class.tx_reports_reports_status_systemstatus.php:214ReplyDoneclass.tx_reports_reports_status_systemstatus.php:219ReplyPhpStorm kindly formatted the line during pasting because it was too long. Doneclass.tx_reports_reports_status_systemstatus.php:238ReplyIt was there to reflect the logic better, but I changed it. -
Jigal van Hemert uploaded patch set 2 09/20/11, 14:28
-
Xavier Perseguers commented on patch set 3 09/20/11, 14:28
(2 inline comments) -
Xavier Perseguers commented on patch set 3 09/20/11, 14:28
Fails It crashes when EXT:dbal is active: #1: PHP Catchable Fatal Error: Argument 2 passed to tx_dbal_installtool::setRequiredPhpModules() must be an instance of tx_install, instance of tx_reports_reports_status_SystemStatus given, called in typo3/sysext/reports/reports/status/class.tx_reports_reports_status_systemstatus.php on line 225 and defined in typo3/sysext/dbal/class.tx_dbal_installtool.php line 79 -
Xavier Perseguers commented on patch set 3 09/20/11, 14:28
Fine with me, I created a task for that: http://forge.typo3.org/issues/30087 but I still have a bug when using the hook: The following PHP module(s) is/are missing: mssql_odbc, mssql_odbc. You need to install and enable these modules to let TYPO3 function correctly. The missing module appears twice! -
Jigal van Hemert uploaded patch set 3 09/20/11, 14:28
-
Jigal van Hemert commented on patch set 3 09/20/11, 14:28
@Xavier The hooksubscriber in dbal has a type hint tx_install for the second argument. It doesn't use this object at all. Solutions: 1. remove type hint 2. make a second, identical hooksubscriber with a different type hint (meaning duplicate code) What do you think? -
Ernesto Baschny commented on patch set 4 V 0 09/20/11, 14:28
by team member; Looks good to me, approved -
Oliver Hader commented on patch set 4 09/20/11, 14:28
Looks good to me, approved Looks good, personally however I'd opt for having the list of required PHP modules centralized, e.g. as a constant in config_default.php -
Xavier Perseguers commented on patch set 4 09/20/11, 14:28
Verified; Looks good to me, but someone else must approve -
Jigal van Hemert uploaded patch set 4 09/20/11, 14:28
-
Tymoteusz Motylewski commented on patch set 4 09/20/11, 14:28
(1 inline comment)class.tx_reports_reports_status_systemstatus.php:37Doesn't TYPO3 requir also curl ? -
Mr. Jenkins commented on patch set 1 09/20/11, 14:28
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1919/ : SUCCESS -
Mr. Jenkins commented on patch set 2 09/20/11, 14:28
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1929/ : SUCCESS -
Mr. Jenkins commented on patch set 3 09/20/11, 14:28
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1930/ : SUCCESS -
Mr. Jenkins commented on patch set 4 09/20/11, 14:28
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1936/ : SUCCESS -
Jigal van Hemert commented on patch set 4 09/20/11, 14:28
(1 inline comment)